Closed
Bug 953732
Opened 10 years ago
Closed 10 years ago
Javascript error when resetting the font size to default
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
0.2b2
People
(Reporter: romain, Assigned: romain)
Details
Attachments
(1 file)
960 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 289 at 2009-12-18 00:57:00 UTC *** This following error occurs on resetting the font size to default, while already being to default. (For example Ctrl+0 on a conversation window). Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch2.clearUserPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://instantbird/content/convZoom.js :: FullZoom_ZoomReset :: line 106" data: no]
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 289 as attmnt 259 at 2009-12-18 01:14:00 UTC *** Avoid outputting the error in the JS Console since its intended. So I added a try/catch block to hide a potential error. I don't think the way it has been done is dirty, since we don't care about the exception at all.
Attachment #8352002 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → romain
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8352002 [details] [diff] [review] patch *** Original change on bio 289 attmnt 259 at 2009-12-18 14:19:33 UTC *** >diff --git a/instantbird/content/convZoom.js b/instantbird/content/convZoom.js >+ catch (ex) {}; > }, Nit: no semicolon after a try/catch block.
Attachment #8352002 -
Flags: review?(florian) → review+
Comment 3•10 years ago
|
||
*** Original post on bio 289 at 2010-01-16 12:07:23 UTC *** This was fixed but we forgot to resolve the bug. https://hg.instantbird.org/instantbird/rev/b1ac924f8571
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•