Closed
Bug 953777
Opened 11 years ago
Closed 11 years ago
Give the user a way to set a buddy icon and a display name
Categories
(Instantbird Graveyard :: Contacts window, enhancement)
Instantbird Graveyard
Contacts window
Tracking
(Not tracked)
RESOLVED
FIXED
0.3b1
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [0.3-blocking])
Attachments
(3 files, 5 obsolete files)
37.21 KB,
image/png
|
Details | |
18.62 KB,
image/png
|
Details | |
49.21 KB,
patch
|
Details | Diff | Splinter Review |
*** Original post on bio 334 at 2010-02-16 16:08:00 UTC ***
*** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•11 years ago
|
||
*** Original post on bio 334 as attmnt 267 at 2010-02-16 16:08:00 UTC ***
The toolbar at the top of the buddy list should allow the user to view and set a buddy icon and a display name.
The attachment is a XUL mockup/work-in-progress.
Assignee | ||
Comment 2•11 years ago
|
||
*** Original post on bio 334 as attmnt 268 at 2010-02-16 16:10:00 UTC ***
This is a screenshot of how this should look on Mac.
The attached mockup in comment 0 doesn't produce exactly this result, there's an issue with the alignment of the label containing the status text.
Assignee | ||
Comment 3•11 years ago
|
||
*** Original post on bio 334 as attmnt 269 at 2010-02-16 16:11:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Assignee | ||
Updated•11 years ago
|
Whiteboard: [0.3-blocking]
Assignee | ||
Comment 4•11 years ago
|
||
*** Original post on bio 334 as attmnt 610 at 2011-05-05 16:20:00 UTC ***
Updated attachment 8352009 [details] [diff] [review] (bio-attmnt 267) and fixed the issue mentioned in comment 1.
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8352009 [details] [diff] [review]
WIP
*** Original change on bio 334 attmnt 267 at 2011-05-05 16:20:51 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352009 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
*** Original post on bio 334 as attmnt 611 at 2011-05-06 15:45:00 UTC ***
Added:
- JS code in the buddy list to open a file picker when the icon place holder is clicked.
- C++ code in purpleCoreService to store the chosen icon in the profile folder, keep track of it, and fire a user-icon-changed notification
- JS code in the buddy list to display the new icon when it's changed.
Next:
- C++ code in purpleAccount to observe the user-icon-changed notification and propagate new icons to the servers of libpurple accounts.
This should resize and convert the new icon to a format acceptable by the protocol plugin, store the new icon in libpurple's buddy icon store, and keep the handle of the stored icon in the account preferences.
- When loading a libpurple account, load the stored icon handle from the account preferences and reapply it.
- Apply the current icon when a new account is created.
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8352353 [details] [diff] [review]
WIP 2
*** Original change on bio 334 attmnt 610 at 2011-05-06 15:45:29 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352353 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•11 years ago
|
||
*** Original post on bio 334 as attmnt 617 at 2011-05-10 22:37:00 UTC ***
Done:
Almost all purplexpcom and libpurple changes needed for the buddy icons. Buddy icons work correctly with this patch.
Next:
- apply the current buddy icon to new accounts.
- ensure that it's possible to remove the icon (setting the new icon to NULL should remove the existing icon. I haven't verified that this works so I assume it currently doesn't).
- Check/fix the CSS on Windows/Linux.
- The display name part.
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 8352354 [details] [diff] [review]
WIP 3
*** Original change on bio 334 attmnt 611 at 2011-05-10 22:37:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352354 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
*** Original post on bio 334 as attmnt 619 at 2011-05-12 00:29:00 UTC ***
Done:
The "Next" part of comment 5 (buddy icon related items only).
Next:
Setting the display name.
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 8352360 [details] [diff] [review]
WIP 4
*** Original change on bio 334 attmnt 617 at 2011-05-12 00:29:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352360 -
Attachment is obsolete: true
Assignee | ||
Comment 12•11 years ago
|
||
*** Original post on bio 334 as attmnt 620 at 2011-05-12 17:01:00 UTC ***
I think it's ready (for review?).
Assignee | ||
Comment 13•11 years ago
|
||
Comment on attachment 8352362 [details] [diff] [review]
WIP 5
*** Original change on bio 334 attmnt 619 at 2011-05-12 17:01:39 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352362 -
Attachment is obsolete: true
Assignee | ||
Comment 14•11 years ago
|
||
*** Original post on bio 334 at 2011-05-12 17:21:59 UTC ***
Pushed attachment 8352363 [details] [diff] [review] (bio-attmnt 620) as https://hg.instantbird.org/instantbird/rev/e52ac1260bb5
-> Fixed.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: 1.0 → 0.3b1
Assignee | ||
Updated•11 years ago
|
Comment 15•11 years ago
|
||
*** Original post on bio 334 at 2011-05-14 16:23:16 UTC ***
I just found a wrong case in an id-attribute but I guess nobody will care? ;)
displayNameAndstatusMessageStack
Assignee | ||
Comment 16•11 years ago
|
||
*** Original post on bio 334 at 2011-05-16 14:27:54 UTC ***
Fixed a bug reported by even in the way the "Display Name" empty text is set after finishing an edit without entering anything in the textbox: http://hg.instantbird.org/instantbird/rev/7f1f36534832
Assignee | ||
Comment 17•11 years ago
|
||
*** Original post on bio 334 at 2011-05-19 13:23:40 UTC ***
More or less follow-ups:
* https://hg.instantbird.org/instantbird/rev/13baeefb20d8 - add notifications when a buddy icon for a contact/buddy/conversation is changed.
* Bug 953888 (bio 448) - ability for message themes to display the user's own icon.
You need to log in
before you can comment on or make changes to this bug.
Description
•