953778 - Going offline should stop reconnection timers

Status: RESOLVED WORKSFORME

(Chat Core :: General, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 335 at 2010-02-18 15:01:00 UTC ***

If the user is going offline (either by setting the status to offline or by getting disconnected from the network), the timers used for automatic reconnection of accounts that suffered from connection errors should stop.

Maybe in this situation we should also remove the connection error message? Not sure.

Comment 1

[Florian Quèze [:florian]]

*** Original post on bio 335 at 2012-06-08 16:30:22 UTC ***

This is already implemented (probably by bug 954193 (bio 759)):

http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#590
590           else if (statusType == Ci.imIStatusInfo.STATUS_OFFLINE &&
591                    this._reconnectTimer)
592             this.cancelReconnection();

I'll need to find something else to blame for the strange reconnection attempts I was seeing recently.

The fact that when switching to offline we disconnect connected accounts but not connecting account sounds like a good candidate:
587           if (statusType == Ci.imIStatusInfo.STATUS_OFFLINE &&
588               this.connected)
589             this.prplAccount.disconnect();