Closed Bug 953882 Opened 10 years ago Closed 10 years ago

Minimize conversation windows with the Escape key

Categories

(Instantbird Graveyard :: Conversation, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: benediktp)

Details

Attachments

(1 file)

*** Original post on bio 441 by John Doe <buggy AT mailinator.com> at 2010-07-10 10:25:00 UTC ***

Hitting ESC should minimize the active conversation window.

IM is something you want to have running all the time, but it should be as easy as possible to get the windows out of the way without closing them altogether. A conversation window may pop up when you're busy, and ESC seems the most intuitive way to say "don't bother me now (but stay around for later)".
*** Original post on bio 441 at 2010-09-03 16:25:51 UTC ***

This sounds like a good idea. It can be useful either if you want to stay concentrated on something you are doing, or if there's someone seeing your screen and you don't want that person to have the time to read the conversation.

We discussed it yesterday on IRC:
<Mic> flo: do you have a minute, I'd like to discuss something about [...] bug 953882 (bio 441)
<Mic> ESCAPE key minimizes the conversation window. Three line patch, if it shouldn't be customizable. A bit more if it should be possible to switch off this behaviour. I prefer the latter.
<flo> escape key to minimize a conversation window seems ok.
<flo> if there's no other use for the key, and as minimizing doesn't cause any dataloss, I don't see the need to switch off this behavior
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Attached patch PatchSplinter Review
*** Original post on bio 441 as attmnt 443 at 2010-12-23 16:15:00 UTC ***

Ok, a small and simple fix for this.
You can't switch this off as per comment 1, you can't customize it either.

The only use I've seen for the escape key is to close the context menus and the tab list and it's not interfering with this.
Attachment #8352186 - Flags: review?(florian)
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Comment on attachment 8352186 [details] [diff] [review]
Patch

*** Original change on bio 441 attmnt 443 at 2010-12-23 16:46:42 UTC ***

>@@ -109,6 +110,7 @@
>     <key id="key_find" key="&findOnCmd.commandkey;" command="cmd_find" modifiers="accel"/>
>     <key id="key_findAgain" key="&findAgainCmd.commandkey;" command="cmd_findAgain" modifiers="accel"/>
>     <key id="key_findPrevious" key="&findAgainCmd.commandkey;" command="cmd_findPrevious" modifiers="accel,shift"/>
>+    <key id="key_minimizeWindow" keycode="VK_ESCAPE" command="cmd_minimizeWindow" />

Nit: no space before /> (I'll change this before pushing the patch).

r=me, even though I'm surprised it doesn't conflict with the key_minimizeWindow of the Mac Window menu (http://mxr.mozilla.org/mozilla-central/source/toolkit/content/macWindowMenu.inc#11).
Attachment #8352186 - Flags: review?(florian) → review+
*** Original post on bio 441 at 2010-12-24 16:01:02 UTC ***

Fixed, thanks!
https://hg.instantbird.org/instantbird/rev/73b6e181dc25
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.3a1
*** Original post on bio 441 at 2011-02-07 15:13:26 UTC ***

Verified fixed on 0.3a1
Status: RESOLVED → VERIFIED
Summary: minimize with ESC key → Minimize conversation windows with the Escape key
You need to log in before you can comment on or make changes to this bug.