Closed Bug 953922 Opened 10 years ago Closed 10 years ago

Instantbird default theme has no preview image

Categories

(Instantbird Graveyard :: Other, defect)

Product:
Instantbird Graveyard
Component:
Other
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benediktp, Assigned: FeuerFliege)

Details

Attachments

(3 files, 5 obsolete files)

The logo that must be used for the theme preview
2.30 KB, image/png
Details
updated icons
13.54 KB, image/png
benediktp
: review+
Details
patch to add preview image
18.41 KB, patch
benediktp
: review+
Details | Diff | Splinter Review 
*** Original post on bio 483 at 2010-08-23 21:37:00 UTC ***

The Instantbird default theme has no preview image on the Themes tab of the addon manager.
*** Original post on bio 483 at 2010-08-23 21:54:54 UTC ***

Tymerkaev said on the chat that he'll take care of this one. Assigning it to him.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
*** Original post on bio 483 at 2010-10-04 15:21:14 UTC ***

In the build logs we can see that there are actually 2 missing images in the theme:
Warning: package error or possible missing or unnecessary file: bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/icon.png (package-manifest, 261).
Warning: package error or possible missing or unnecessary file: bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png (package-manifest, 262).

For Linux the preview.png image may be reused directly: http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser/preview.png
For Windows and Mac, the Firefox preview.png images are really Firefox-specific (with the back/forward/stop/reload buttons visible).

You can also take some inspiration in what Thunderbird does:
Windows: http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/preview.png
Mac: http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/preview.png
Linux: http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/preview.png

The icon.png image is reusable on Windows and Linux:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/icon.png
http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser/icon.png
On Mac, Firefox uses the "Back" button image so it's not really great for us...

Hope this helps! :)
Attached image preview.png (obsolete) — 
*** Original post on bio 483 as attmnt 363 by tymerkaev AT gmail.com at 2010-10-05 16:54:00 UTC ***

icon.png should include chrome://mozapps/skin/extensions/themeGeneric.png in jar.mn.
Comment on attachment 8352105 [details]
preview.png

*** Original change on bio 483 attmnt 363 by tymerkaev AT gmail.com at 2010-10-05 17:00:41 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352105 - Flags: review?(bugzilla)
Comment on attachment 8352105 [details]
preview.png

*** Original change on bio 483 attmnt 363 by idechix AT instantbird.org at 2010-10-26 11:30:59 UTC ***

The font used for the logo is not the good one. I'm going to give you a png to fix that.

I think it would be nice to set the must famous networks on the first line : AIM, MSN, Yahoo and Google talk. (I don't tell you to set Facebook logo on the first line because I think it is a bit too flashy)

My last comment will focus on the alignments. It would be nice if you could reduce space between logos to get something that looks more like that : http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/preview.png (the text is a bit bigger than the logos below)
Attachment #8352105 - Flags: review?(bugzilla) → review-
*** Original post on bio 483 as attmnt 390 by idechix AT instantbird.org at 2010-10-26 11:35:00 UTC ***

I give you that png, so you can use it for the theme preview.

This is the good font in the good size and the good color.
Please do not resize it or change its color.
Attached image preview including Quentin's comments (obsolete) — 
*** Original post on bio 483 as attmnt 954 at 2011-10-29 19:30:00 UTC ***

Seemd like a quick one. I hope you don't mind ...
Assignee: bugzilla → bug
Comment on attachment 8352696 [details]
preview including Quentin's comments

*** Original change on bio 483 attmnt 954 at 2011-10-29 21:31:45 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352696 - Flags: review?(bugzilla)
Comment on attachment 8352696 [details]
preview including Quentin's comments

*** Original change on bio 483 attmnt 954 by idechix AT instantbird.org at 2011-10-30 14:04:55 UTC ***

I like this one. Thanks!
Attachment #8352696 - Flags: review?(bugzilla) → review+
*** Original post on bio 483 at 2011-11-01 14:32:20 UTC ***

Now that we have a good preview image, something still needs to be done for the icon, and finally a patch to include all of that :).
*** Original post on bio 483 as attmnt 1302 at 2012-04-05 23:17:00 UTC ***

The white background stood out too much over the add-on manager's patterned background. I removed the background of the image with a background removal tool from PSP 14. The result seems good enough.

Do we need the icons, by the way? The default theme icons seem to be OK.

By the way, I had a look at the makefile and I don't think I know enough about it to make the changes to it.
*** Original post on bio 483 at 2012-06-13 13:03:57 UTC ***

None of the images here seem ready to use. Attachment 8353055 [details] (bio-attmnt 1302) has broken transparency, attachment 8352696 [details] (bio-attmnt 954) has no transparency, attachment 8352105 [details] (bio-attmnt 363) doesn't have the correct Instantbird logo. + all of them have outdated icons (the XMPP and twitter icons have changed recently).
Attached image updated icons (obsolete) — 
*** Original post on bio 483 as attmnt 1712 at 2012-06-27 21:58:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8352696 [details]
preview including Quentin's comments

*** Original change on bio 483 attmnt 954 at 2012-06-27 21:58:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352696 - Attachment is obsolete: true
Attached patch add preview image (obsolete) — — Splinter Review 
*** Original post on bio 483 as attmnt 1713 at 2012-06-27 22:56:00 UTC ***

I think that is all it needs, isn't it?
Attachment #8353471 - Flags: feedback?(florian)
Comment on attachment 8353470 [details]
updated icons

*** Original change on bio 483 attmnt 1712 at 2012-06-27 22:57:49 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353470 - Flags: feedback?(bugzilla)
*** Original post on bio 483 at 2012-06-28 13:50:35 UTC ***

(In reply to comment #12)
> Created attachment 8353471 [details] [diff] [review] (bio-attmnt 1713) [details]
> add preview image
> 
> I think that is all it needs, isn't it?

9:46:47 AM - clokep_work: flo: Where is that IRC icon from? The AIM icon seems wrong. The Twitter icon seems outdated. The MSN icon differs from what we currently use.

Apparently I was wrong about the Twitter icon though, it's actually the newer one.
*** Original post on bio 483 at 2012-06-28 15:13:01 UTC ***

There is no standard IRC icon so I took it from instantbird.com¹
AIM changed its icon to this.²
MSN (WLM) is the current one³, maybe the icon should be updated elsewhere, too.

¹ <http://www.instantbird.com/images/services/icon-irc.png>
² <http://www.aim.com/> and <http://articles.businessinsider.com/2011-11-17/news/30409289_1_logo-change-brand-new-aol>
³ <http://explore.live.com/windows-live-messenger>
*** Original post on bio 483 at 2012-06-28 15:40:02 UTC ***

(In reply to comment #14)
> There is no standard IRC icon so I took it from instantbird.com¹
> AIM changed its icon to this.²
> MSN (WLM) is the current one³, maybe the icon should be updated elsewhere, too.
I think we should be using the icons that are in Instantbird, not from scattered online.
*** Original post on bio 483 at 2012-06-28 15:43:15 UTC ***

Also, I think Facebook chat is more relevant than ICQ in most countries.
*** Original post on bio 483 at 2012-06-29 08:22:45 UTC ***

>
> I think we should be using the icons that are in Instantbird, not from
> scattered online.

True, I will fix that. I used the latest icons because outdated icons where mentioned in comment 10.
Attached image updated icons — 
*** Original post on bio 483 as attmnt 1715 at 2012-06-29 09:22:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8353470 [details]
updated icons

*** Original change on bio 483 attmnt 1712 at 2012-06-29 09:22:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353470 - Attachment is obsolete: true
Attachment #8353470 - Flags: feedback?(bugzilla)
*** Original post on bio 483 at 2012-06-29 10:07:30 UTC ***

(In reply to comment #18)
> Created attachment 8353473 [details] (bio-attmnt 1715) [details]
> updated icons

Icons/font/transparency seem to be fine now.
I like that you replaced the IRC icon  (which is little meaningful in my opinion) with the Facebook icon. I'd r+ this if I were asked to ;)
*** Original post on bio 483 at 2012-06-29 10:31:41 UTC ***

I agree that this seems fine now. :)
Comment on attachment 8353473 [details]
updated icons

*** Original change on bio 483 attmnt 1715 at 2012-06-29 10:37:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353473 - Flags: review?(benediktp)
Comment on attachment 8353473 [details]
updated icons

*** Original change on bio 483 attmnt 1715 at 2012-06-29 10:59:05 UTC ***

Preview image looks good, thanks for fixing this after such a long time. Let's hope the packaging changes are also fine :)
Attachment #8353473 - Flags: review?(benediktp) → review+
Comment on attachment 8353055 [details]
Attachment 954 [details]: 'preview including Quentin's comments', with transparent background

*** Original change on bio 483 attmnt 1302 at 2012-06-29 10:59:43 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353055 - Attachment is obsolete: true
Comment on attachment 8352105 [details]
preview.png

*** Original change on bio 483 attmnt 363 at 2012-06-29 11:00:52 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352105 - Attachment is obsolete: true
*** Original post on bio 483 as attmnt 1718 at 2012-06-29 11:25:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353476 - Flags: review?
Comment on attachment 8353471 [details] [diff] [review]
add preview image

*** Original change on bio 483 attmnt 1713 at 2012-06-29 11:25:41 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353471 - Attachment is obsolete: true
Attachment #8353471 - Flags: feedback?(florian)
Comment on attachment 8353476 [details] [diff] [review]
patch to add preview image

*** Original change on bio 483 attmnt 1718 at 2012-07-01 12:49:18 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353476 - Flags: review? → review?(benediktp)
Comment on attachment 8353476 [details] [diff] [review]
patch to add preview image

*** Original change on bio 483 attmnt 1718 at 2012-07-02 14:24:25 UTC ***

I can't actually try the patch but it applies, the new file is in the same folder as the others and the change to the makefile looks reasonable.
I'll r+ it based on this and that flo would complain before check-in if it wasn't fine ;)
Attachment #8353476 - Flags: review?(benediktp) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 483 at 2012-07-14 16:37:18 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/b24a37bbc830

Thanks for fixing this. :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: