Closed
Bug 953924
Opened 10 years ago
Closed 10 years ago
Re-ordering conversation tabs with the keyboard is broken
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: benediktp, Assigned: benediktp)
References
Details
Attachments
(1 file)
1.13 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 485 at 2010-09-01 19:02:00 UTC *** It's not possible to re-order or detach tabs using the keyboard. Maybe a shortcut like ctrl+shift+left/right would do (reason: re-ordering the accounts on the account manager uses ctrl+shift+up/down) . Would still not allow to detach tabs or to move them between windows. To be decided if this bug is even fix-worthy. Firefox doesn't allow resorting tabs with the keyboard either. By the way the modifiers mentioned here are referring to a Windows system. Would naturally have to be changed for each system accordingly.
Comment 1•10 years ago
|
||
*** Original post on bio 485 by James Teh <jamie AT nvaccess.org> at 2012-08-11 16:12:38 UTC *** Firefox does (now at least) allow you to reorder tabs using the keyboard while focused in the tab control: control+left/control+right. I'd suggest the same would be ideal for Instantbird.
Assignee | ||
Updated•10 years ago
|
Severity: minor → normal
Summary: Not possible to re-order / detach tabs using the keyboard → Re-ordering conversation tabs with the keyboard is broken
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 485 as attmnt 1972 at 2012-10-17 12:50:00 UTC *** The check for the source of the event was broken as it seems. I've dumped the localname, replaced the check and verified that it worked. I don't know why it is coming from the "tabconversation" though. I've morphed this bug to cover the re-order part only and will file a new one for detaching tabs using the keyboard.
Attachment #8353731 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 485 at 2012-10-17 12:53:13 UTC *** (In reply to comment #2) > I've morphed this bug to cover the re-order part only and will file a new one > for detaching tabs using the keyboard. Filed as bug 955160 (bio 1731).
Comment 4•10 years ago
|
||
*** Original post on bio 485 at 2012-10-17 12:57:11 UTC *** (In reply to comment #2) > I don't know why it > is coming from the "tabconversation" though. "tabconversation" is the name of our fork of Firefox's "tabbrowser". It's the same thing. Apparently I forgot one instance during my search&replace when I added Firefox-like tabs for Instantbird 0.2. Thanks for catching it! :-)
Comment 5•10 years ago
|
||
Comment on attachment 8353731 [details] [diff] [review] Patch *** Original change on bio 485 attmnt 1972 at 2012-10-17 13:10:39 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353731 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 485 at 2012-10-25 12:10:18 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/778e140443c5 Thanks for fixing this old bug. :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
Comment 7•10 years ago
|
||
*** Original post on bio 485 by Ed Morley [:edmorley] <instantbird AT edmorley.co.uk> at 2012-11-02 09:11:02 UTC *** This unfortunately regressed using ctrl+left/right to reposition the cursor word by word in the chat text field (which I use to expedite correcting any typos). Any chance we could require use a different shortcut key for re-ordering tabs (which I am pretty sure would be a less frequent operation for most people)?
Comment 8•10 years ago
|
||
*** Original post on bio 485 by Ed Morley [:edmorley] <instantbird AT edmorley.co.uk> at 2012-11-02 09:11:57 UTC *** s/require//
Comment 9•10 years ago
|
||
*** Original post on bio 485 at 2012-11-02 09:21:39 UTC *** (In reply to comment #6) > This unfortunately regressed using ctrl+left/right to reposition the cursor See bug 955177 (bio 1746).
You need to log in
before you can comment on or make changes to this bug.
Description
•