953933 - Add shortcut <modifier>+<number n> to access n-th tab in conversation window

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, enhancement)

Description

[Benedikt Pfeifer]

*** Original post on bio 496 at 2010-09-12 09:21:00 UTC ***

Firefox offers the shortcut CTRL+<number n> to access the n-th tab in the browser window. Would be useful to have the same for conversation tabs.

Mapping:
  Zero: No action.
  One to eight: First to eighth tab; if there's no n-th tab, do nothing.
  Nine: Always select last tab, even if its number is less than nine.

Comment 2

[Benedikt Pfeifer]

*** Original post on bio 496 at 2011-01-02 15:19:10 UTC ***

> Fioravanti Diego 2011-01-02 15:36:17 CET
>
> It's possible that it's not a bug but a missing feature.
> Usually under GNOME with firefox, nautilus, pidgin it's 
> possible switch between tab using ALT + 1,2,3 etc, but
> it's not possible in Instantbird.

I didn't know it's possible to use the ALT key as well. Changing the summary to reflect the situation. Thanks for helping!

Comment 3

[Instantbot]

*** Original post on bio 496 by Fioravanti Diego <diravan AT gmail.com> at 2011-01-02 15:27:36 UTC ***

Ok, thank you. But all other application use ALT + number, including Firefox. I think it's quite confusing that instantbird use CTRL + number.

Comment 4

[Benedikt Pfeifer]

*** Original post on bio 496 at 2011-01-02 16:54:57 UTC ***

(In reply to comment #3)
> Ok, thank you. But all other application use ALT + number, including Firefox. I
> think it's quite confusing that instantbird use CTRL + number.

On Windows, Firefox uses CTRL+<number> and ALT+<number> doesn't work; we should have an OS specific solution so everyone gets what he's used to.

Comment 5

[Instantbot]

*** Original post on bio 496 by Fioravanti Diego <diravan AT gmail.com> at 2011-01-02 17:09:56 UTC ***

(In reply to comment #4)
> (In reply to comment #3)
> > Ok, thank you. But all other application use ALT + number, including Firefox. I
> > think it's quite confusing that instantbird use CTRL + number.
> 
> On Windows, Firefox uses CTRL+<number> and ALT+<number> doesn't work; we should
> have an OS specific solution so everyone gets what he's used to.

Ah, ok. I use Ubuntu so I use ALT + <number>. I agree with you that the OS specific solution it's the better way to do that.

Comment 6

[Florian Quèze [:florian]]

Attachment: Patch v1

*** Original post on bio 496 as attmnt 597 at 2011-04-22 12:55:00 UTC ***

This is a straight port of the Firefox code at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#364

Comment 7

[Florian Quèze [:florian]]

Attachment: Patch v2

*** Original post on bio 496 as attmnt 598 at 2011-04-22 14:18:00 UTC ***

The same with some more code to handle Command+shift+left/right arrow on Mac.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8352339 [details] [diff] [review]
Patch v1

*** Original change on bio 496 attmnt 597 at 2011-04-22 14:18:10 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 9

[Florian Quèze [:florian]]

*** Original post on bio 496 at 2011-04-22 17:40:16 UTC ***

https://hg.instantbird.org/instantbird/rev/0b4aafaedc93