Closed Bug 953984 Opened 7 years ago Closed 7 years ago

Add-ons manager opened from General Options

Categories

(Instantbird :: Other, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: clokep)

Details

Attachments

(2 files)

*** Original post on bio 546 by Michal Stanke <michal.stanke AT mikk.cz> at 2010-10-13 12:04:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached image screenshot
*** Original post on bio 546 as attmnt 371 by michal.stanke AT mikk.cz at 2010-10-13 12:04:00 UTC ***

Add-ons manager isn't opened properly from General by the Manage Add-ons... button.
No option in "Tools for add-ons" menu is working till you choose something in the menu on the left (Extensions, Appearance, ...). Also the the list is blank.
*** Original post on bio 546 at 2010-10-13 12:12:26 UTC ***

Happens also on Windows XP.
I haven't found anything on the Mozilla bugtracker yet, maybe I need to look closer later. For the time being: there's an error on the errorconsole:

Error: invalid 'in' operand window.arguments[0]
Source File: chrome://mozapps/content/extensions/extensions.js
Line: 443
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
*** Original post on bio 546 at 2010-10-13 12:59:40 UTC ***

http://hg.instantbird.org/instantbird/file/a8fc7f06ff06/instantbird/content/preferences/main.js#l86 needs to specify where to open to, like http://hg.instantbird.org/instantbird/file/a8fc7f06ff06/instantbird/content/menus.js#l38 does, I believe. (I.e. you have to choose to open to extensions.)
*** Original post on bio 546 as attmnt 373 at 2010-10-13 14:30:00 UTC ***

Taking this.  Fixed by copying the code that is used in the menu system (also it now matches the above code in that file).
Attachment #8352116 - Flags: review?(florian)
Assignee: nobody → clokep
Comment on attachment 8352116 [details] [diff] [review]
Fixes extension manager from prefs

*** Original change on bio 546 attmnt 373 at 2010-10-13 15:41:45 UTC ***

Good fix!

I think we should keep the EMURL constant (I'll bring it back when pushing this).
Attachment #8352116 - Flags: review?(florian) → review+
*** Original post on bio 546 at 2010-10-13 15:45:13 UTC ***

Pushed as https://hg.instantbird.org/instantbird/rev/b6c87968f528
Thanks for fixing this so quickly!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.3a1
You need to log in before you can comment on or make changes to this bug.