Closed Bug 954036 Opened 8 years ago Closed 8 years ago

Right click on links in conversation browser broken

Categories

(Instantbird :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: florian)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 599 at 2010-11-24 10:56:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
*** Original post on bio 599 as attmnt 405 at 2010-11-24 10:56:00 UTC ***

iLobster pointed out that right clicking doesn't bring up the context menu on hyperlinks at the moment (using keyboard, (context menu key on Windows / Shift+F10 is working). I think it worked before so maybe a regression occured when the changed support for link handling in browser elements landed? (https://hg.instantbird.org/instantbird/rev/8c4bcf263a8d )

Fix:
It works for me when adding button="0" to the handler definition. See attached patch.
Result: 
Left mouse button still opens links in default internet browser, and so do Enter- and Return-keys. The right mouse button opens the context menu again.

Thanks to iLobster again for bringing this to attention! :)
Attachment #8352148 - Flags: review?(florian)
Comment on attachment 8352148 [details] [diff] [review]
Restrict handler to left-click events

*** Original change on bio 599 attmnt 405 at 2010-11-24 13:52:31 UTC ***

This patch prevents opening links with middle clicks (we had bug 953879 (bio 438) on this and it was fixed, even though I didn't know about it, by the changeset that caused the regression here).
Attachment #8352148 - Flags: review?(florian) → review-
Attached patch Patch v2Splinter Review
*** Original post on bio 599 as attmnt 406 at 2010-11-24 13:53:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352149 - Flags: review?(benediktp)
Comment on attachment 8352148 [details] [diff] [review]
Restrict handler to left-click events

*** Original change on bio 599 attmnt 405 at 2010-11-24 13:53:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352148 - Attachment is obsolete: true
Comment on attachment 8352149 [details] [diff] [review]
Patch v2

*** Original change on bio 599 attmnt 406 at 2010-11-24 14:09:25 UTC ***

Fixes the problem and applies correctly. Thanks for making it fix bug 953879 (bio 438) as well.
Attachment #8352149 - Flags: review?(benediktp) → review+
*** Original post on bio 599 at 2010-11-24 15:53:55 UTC ***

Fixed: https://hg.instantbird.org/instantbird/rev/f3e55cf1266b

It's great to have nightly testers who report regressions so quickly! Thanks!
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 8 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
*** Original post on bio 599 at 2011-04-13 16:03:04 UTC ***

Cleaning up some old bugs to add milestones.
Target Milestone: --- → 0.3a1
You need to log in before you can comment on or make changes to this bug.