Closed Bug 954065 Opened 10 years ago Closed 10 years ago

Remove workaround for bug 503048

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file)

*** Original post on bio 629 at 2010-12-14 21:12:00 UTC ***

In the conversation binding (http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#148) there's a comment:
> // We can remove this test once we are sure we will only run on
> // mozilla plateforms that include the fix for bio 503048.
> if ("destroy" in this.findbar)

But 503048 is adding a destroy method to the findbar.  Now that we're on Mozilla 2 this could be removed.
*** Original post on bio 629 as attmnt 424 at 2010-12-14 21:16:00 UTC ***

Not sure when we should take this (i.e. if Linux is still running older XULRunners, though that bug says it was fixed in 1.9.2a1, so if they're on any recent 1.9.2 we should be OK?).
Attachment #8352167 - Flags: review?(florian)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8352167 [details] [diff] [review]
Removes the comment and workaround

*** Original change on bio 629 attmnt 424 by tymerkaev AT gmail.com at 2010-12-14 21:29:02 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352167 - Attachment is patch: true
Attachment #8352167 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 8352167 [details] [diff] [review]
Removes the comment and workaround

*** Original change on bio 629 attmnt 424 at 2010-12-15 11:55:32 UTC ***

We can take this now. Our current trunk won't work on anything older than Mozilla 2.

On the 0.2 branch, we use 1.9.2 and try to not break too much compatibility with 1.9.1 because some linux distribution may care.
Attachment #8352167 - Flags: review?(florian) → review+
*** Original post on bio 629 at 2010-12-15 12:20:12 UTC ***

Fixed, thanks.
https://hg.instantbird.org/instantbird/rev/ba4b9401791b
There was a second instance of that hack/comment that I removed too, and I removed some blank lines that were used to separate the hack from the real code.

We should probably remove that code duplication some day (create a _forgetConv method maybe?), but it's out of the scope of this bug.
*** Original post on bio 629 at 2010-12-20 04:18:17 UTC ***

This was closed and checked in. Filed bug 954073 (bio 637) about comment #3

(In reply to comment #3)
> We should probably remove that code duplication some day (create a _forgetConv
> method maybe?), but it's out of the scope of this bug.
Blocks: 954073
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
OS: Windows 7 → All
Hardware: x86 → All
Target Milestone: --- → 0.3a1
You need to log in before you can comment on or make changes to this bug.