Closed Bug 954095 Opened 10 years ago Closed 10 years ago

Override protocol accounts don't work well now that GenericAccountPrototype implements things locally

Categories

(Chat Core :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

*** Original post on bio 660 at 2011-01-23 14:42:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Patch v1Splinter Review
*** Original post on bio 660 as attmnt 495 at 2011-01-23 14:42:00 UTC ***

Especially, the "Join Chat" window is broken for Google Talk since the landing of bug 954083 (bio 648).
Attachment #8352238 - Flags: review?(clokep)
*** Original post on bio 660 at 2011-01-23 14:48:05 UTC ***

Comment on attachment 8352238 [details] [diff] [review] (bio-attmnt 495)
Patch v1

>@@ -194,72 +253,32 @@ const GenericAccountPrototype = {

>-  get numericId() this._base.numericId,
>   get protocol() this._protocol,
>-  get autoLogin() this._base.autoLogin,

When reviewing, assume the get protocol() line is removed too (it's redundant with the same getter implementation in the prototype...).
Comment on attachment 8352238 [details] [diff] [review]
Patch v1

*** Original change on bio 660 attmnt 495 at 2011-01-23 15:07:16 UTC ***

Looks good and worked successfully with my JavaScript IRC branch.
Attachment #8352238 - Flags: review?(clokep) → review+
*** Original post on bio 660 at 2011-01-23 15:21:06 UTC ***

https://hg.instantbird.org/instantbird/rev/79887b0140a0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.3a1
You need to log in before you can comment on or make changes to this bug.