954097 - Names are not fully normalized by current normalizedName getters of jsProtoHelper

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 662 at 2011-01-23 15:19:00 UTC ***

The current normalizedName getters just do name.toLowerCase(), this is not enough.
It should at least remove insignificant whitespaces, and maybe do some special handling of some characters. I have '/' in mind which causes issues in the logger code when trying to create a file or folder. Not sure if that should be special cased in the logger or should be handled as part of the name normalization. There may be other characters that we don't want in normalized names.

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 662 at 2011-02-24 19:08:50 UTC ***

This is fixed in http://hg.instantbird.org/instantbird/rev/4e3765a57e17 by removing all /[^a-z0-9]/gi from strings (i.e. leaving only letters & numbers).

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 662 at 2011-04-13 16:04:37 UTC ***

Cleaning up some old bugs to add milestones.