Closed Bug 954128 Opened 10 years ago Closed 10 years ago

Copy paste failures in conversation history

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [0.3-blocking-final])

*** Original post on bio 693 at 2011-02-11 15:26:00 UTC ***

A focus issue in the conversation window is causing extremely annoying copy/paste failures.

Steps to reproduce:
1. Select in the conversation history something you want to paste in some other window.
2. Focus the other window and prepare the area where you want to paste the selected content.
3. Focus again the conversation window and press Ctrl/Command+C
4. Paste the content of the clipboard, and notice that you pasted the previous content of the clipboard, as step 3 did nothing.

Alternative (maybe more common) steps to reproduce:
1. Select something in the conversation history of a conversation window that wasn't focused.
2. Press Ctrl/Command+C
3. Paste the content of the clipboard, and notice that you pasted the previous content of the clipboard, as step 2 did nothing.

The cause is the same in both cases: focusing the conversation window causes the focus to be moved to the textbox, so the Ctrl/Command+C is received by the input box instead of the conversation history.

Possible workarounds:
 - if the textbox is focused when the user uses the copy command, if the selection in the textbox is empty and the selection in the conversation history is not empty, copy from the conversation history even though it's not focused.
 - when the conversation window gets the focus, if the conversation history has a non-empty selection, don't focus the textbox automatically (it will be focused automatically if the user starts typing anyway).

The 2nd (most annoying) way to reproduce given here is most likely a regression from https://hg.instantbird.org/instantbird/rev/1c31b62304a3
The first way is probably older.
*** Original post on bio 693 at 2011-02-11 15:27:07 UTC ***

I think we should at least workaround this before releasing a stable version.
Whiteboard: [0.3-blocking]
Whiteboard: [0.3-blocking] → [0.3-blocking-final]
*** Original post on bio 693 at 2011-06-16 18:13:26 UTC ***

(In reply to comment #0)

>  - if the textbox is focused when the user uses the copy command, if the
> selection in the textbox is empty and the selection in the conversation history
> is not empty, copy from the conversation history even though it's not focused.

Fixed using this approach in https://hg.instantbird.org/instantbird/rev/02a3479e69ac
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
OS: Other → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
*** Original post on bio 693 at 2011-06-17 00:05:52 UTC ***

Follow-up: https://hg.instantbird.org/instantbird/rev/6f9c5004f00d - handle correctly the case of caps lock enabled.
You need to log in before you can comment on or make changes to this bug.