Closed Bug 954178 Opened 10 years ago Closed 10 years ago

top of conversation UI (contact info)

Categories

(Instantbird Graveyard :: Conversation, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [0.3-blocking-beta])

Attachments

(3 files, 2 obsolete files)

*** Original post on bio 744 at 2011-03-28 21:07:00 UTC ***

For IM conversations, the top of the conversation binding should show the display name, icon, status type and status text of the contact.
It should be possible to see which buddy is the conversation target (show a protocol icon?) and to change it, probably with a menupopup listing all the buddies, ordered by availability/preference.

For MUCs, the same area should display the topic (and replace the current notification bar).
Depends on: 954133
*** Original post on bio 744 at 2011-03-28 21:08:13 UTC ***

At least "being able to change the conversation target" blocks the 0.3 release.
Whiteboard: [0.3-blocking]
*** Original post on bio 744 at 2011-04-29 22:40:39 UTC ***

Just so that I don't forget it, the code to display a nice gradient in a toolbar touching the selected tab on Mac is:
<xul:toolbar style="-moz-appearance: none; background-color: -moz-mac-chrome-(in)active; background-image: -moz-linear-gradient(rgba(255,255,255,.43), rgba(255,255,255,0));"/>
Attached patch WIP 1 (obsolete) — Splinter Review
*** Original post on bio 744 as attmnt 624 at 2011-05-18 20:39:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attached patch WIP 2 (obsolete) — Splinter Review
*** Original post on bio 744 as attmnt 626 at 2011-05-19 18:47:00 UTC ***

Works OK on Mac. Remains to do:
 - CSS on Linux/Windows.
 - A way to change the conversation target (will be handled in a different changeset/bug).

This new WIP relies on 2 changesets that I pushed today:
* https://hg.instantbird.org/instantbird/rev/a12fd5ec1fb2 - clean up in conversation.xml to make the code using getAnonymousElementByAttribute readable
* https://hg.instantbird.org/instantbird/rev/8ad8500228a2 - add a way to set the chat topic that isn't IRC specific.
Comment on attachment 8352367 [details] [diff] [review]
WIP 1

*** Original change on bio 744 attmnt 624 at 2011-05-19 18:47:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352367 - Attachment is obsolete: true
Attached patch part 1 (WIP 3)Splinter Review
*** Original post on bio 744 as attmnt 630 at 2011-05-20 01:03:00 UTC ***

The CSS is now correct on Windows/Linux too. I think I'm going to push this soon and do the 'change target' part later.
Comment on attachment 8352369 [details] [diff] [review]
WIP 2

*** Original change on bio 744 attmnt 626 at 2011-05-20 01:03:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352369 - Attachment is obsolete: true
*** Original post on bio 744 at 2011-05-20 01:22:46 UTC ***

Pushed attachment 8352373 [details] [diff] [review] (bio-attmnt 630): https://hg.instantbird.org/instantbird/rev/c66b5ba4ccc1
Blocks: 954225
Blocks: 954226
Blocks: 954227
Depends on: 954232
Blocks: 954233
Whiteboard: [0.3-blocking] → [0.3-blocking-beta]
Comment on attachment 8352373 [details] [diff] [review]
part 1 (WIP 3)

*** Original change on bio 744 attmnt 630 at 2011-05-24 14:03:40 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352373 - Attachment description: WIP 3 → part 1 (WIP 3)
Attached patch part 2 (v1)Splinter Review
*** Original post on bio 744 as attmnt 651 at 2011-05-24 14:05:00 UTC ***

Adds a protocol icon in the top of conversation toolbar. Clicking it (in conversations where there's a contact) opens a menu listing all the possible targets (buddies). Selecting one changes the target of the conversation.
*** Original post on bio 744 as attmnt 652 at 2011-05-24 14:48:00 UTC ***

Additional patch to fix the appearance of the all-targets button on Linux/Windows.
*** Original post on bio 744 at 2011-05-24 14:54:55 UTC ***

Pushed attachment 8352394 [details] [diff] [review] (bio-attmnt 651) and 652 together as https://hg.instantbird.org/instantbird/rev/c856c0b1cd19

Fixed!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.3b1
*** Original post on bio 744 at 2011-05-26 17:46:24 UTC ***

2 follow-ups:

https://hg.instantbird.org/instantbird/rev/dfcb5d529c7c - move the top UI markup into 2 separate bindings (fixes a regression from attachment 8352394 [details] [diff] [review] (bio-attmnt 651) that prevented topic edition)

https://hg.instantbird.org/instantbird/rev/1b90f5e6e4cf - add a tooltip to the alltargets button.
Blocks: 954277
You need to log in before you can comment on or make changes to this bug.