Closed Bug 954202 Opened 8 years ago Closed 8 years ago

Make conversation tabs look like Firefox 4 tabs

Categories

(Instantbird :: Conversation, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [0.3-wanted])

Attachments

(2 files, 3 obsolete files)

*** Original post on bio 768 at 2011-04-30 01:01:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch WIP (works only on Mac) (obsolete) — Splinter Review
*** Original post on bio 768 as attmnt 602 at 2011-04-30 01:01:00 UTC ***

The attached work-in-progress works only on Mac.
Animations when adding/removing tabs are not supported.
Attached patch WIP (Mac and Linux) (obsolete) — Splinter Review
*** Original post on bio 768 as attmnt 604 at 2011-05-02 15:59:00 UTC ***

Also works on Linux.
Comment on attachment 8352345 [details] [diff] [review]
WIP (works only on Mac)

*** Original change on bio 768 attmnt 602 at 2011-05-02 15:59:05 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352345 - Attachment is obsolete: true
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attached patch Works on the 3 supported OSes (obsolete) — Splinter Review
*** Original post on bio 768 as attmnt 605 at 2011-05-02 20:00:00 UTC ***

I would like to test Firefox 4 on my Windows VM to compare the behavior and ensure nothing is broken before pushing this.

Also, the aero version is completely untested, it's just a best effort port of the Firefox code, and it looks so much like black magic that I wouldn't expect it to 'just work' at the first attempt.
Comment on attachment 8352347 [details] [diff] [review]
WIP (Mac and Linux)

*** Original change on bio 768 attmnt 604 at 2011-05-02 20:00:39 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352347 - Attachment is obsolete: true
Attached patch Patch v4Splinter Review
*** Original post on bio 768 as attmnt 606 at 2011-05-04 14:21:00 UTC ***

Fixed some details after testing on Windows XP.

Aero version included but disabled as it's not ready yet. Someone should feel free to work on it in another bug :).
Comment on attachment 8352348 [details] [diff] [review]
Works on the 3 supported OSes

*** Original change on bio 768 attmnt 605 at 2011-05-04 14:21:46 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352348 - Attachment is obsolete: true
*** Original post on bio 768 as attmnt 607 at 2011-05-04 14:22:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
*** Original post on bio 768 at 2011-05-04 14:53:37 UTC ***

https://hg.instantbird.org/instantbird/rev/3e0f99aee2cd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
OS: Other → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 0.3b1
Whiteboard: [0.3-wanted]
Blocks: 954205
Duplicate of this bug: 953972
You need to log in before you can comment on or make changes to this bug.