Closed Bug 95422 Opened 23 years ago Closed 23 years ago

crash when selecting Search [@ nsXBLPrototypeBinding::AttributeChanged]

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.4

People

(Reporter: bugzilla, Assigned: hyatt)

References

Details

(Keywords: crash, topcrash, Whiteboard: critical for 0.9.4)

Crash Data

Attachments

(1 file)

Need a null-check now, since default content can now cause this to be null.
5.20 KB, patch
Details | Diff | Splinter Review
I crash when I select Search in context menu in folderpane. build 20010815 on win2k TB34140379Y
Keywords: crash
Whiteboard: [folderpane]
I dont think this has anything to do with the new folderpane. I just crash everytime!
Assignee: sspitzer → naving
Severity: normal → major
Summary: crash when selecting Search in context menu in folderpane → crash when selecting Search
Whiteboard: [folderpane]
I don't crash with the latest CVS bits. Any more info?
I crash everytime I select Search -> Search Messages using build 2001081504
Here is from talkback, your crash (albeit I still can't reproduce it!): nsXBLPrototypeBinding::AttributeChanged [d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLPrototypeBinding.cpp, line 672] nsXBLBinding::AttributeChanged [d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLBinding.cpp, line 1357] nsXULElement::SetAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3054] nsXULElement::SetAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3110] nsXBLPrototypeBinding::AttributeChanged [d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLPrototypeBinding.cpp, line 672] nsXBLBinding::AttributeChanged [d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLBinding.cpp, line 1357] nsXULElement::SetAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3054] nsXULElement::SetAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 1433] nsXULElement::SetAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3040] nsXULElement::SetAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 1433] XPTC_InvokeByIndex [d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, line 139] XPCWrappedNative::CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp, line 1886] XPC_WN_CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, line 1253] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 809] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2700] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 825] js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 897] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3351] nsJSContext::CallEventHandler [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 947] nsJSEventListener::HandleEvent [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 140] nsEventListenerManager::HandleEventSubType [d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 1197] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 2189] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3707] nsXULCommandDispatcher::UpdateCommands [d:\builds\seamonkey\mozilla\content\xul\document\src\nsXULCommandDispatcher.cpp, line 365] XPTC_InvokeByIndex [d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, line 139] XPCWrappedNative::CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp, line 1886] XPC_WN_CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, line 1253] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 809] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2700] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 825] js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 897] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3351] nsJSContext::CallEventHandler [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 947] nsJSEventListener::HandleEvent [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 140] nsEventListenerManager::HandleEventSubType [d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 1197] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 1872] GlobalWindowImpl::HandleDOMEvent [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 599] DocumentViewerImpl::LoadComplete [d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp, line 1092] nsDocShell::EndPageLoad [d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3726] nsWebShell::EndPageLoad [d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp, line 893] nsDocShell::OnStateChange [d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp, line 3647] nsDocLoaderImpl::FireOnStateChange [d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 1095] nsDocLoaderImpl::doStopDocumentLoad [d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 734] nsDocLoaderImpl::DocLoaderIsEmpty [d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 632] nsDocLoaderImpl::OnStopRequest [d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 563] nsLoadGroup::RemoveRequest [d:\builds\seamonkey\mozilla\netwerk\base\src\nsLoadGroup.cpp, line 517] nsJARChannel::OnStopRequest [d:\builds\seamonkey\mozilla\netwerk\protocol\jar\src\nsJARChannel.cpp, line 591] nsOnStopRequestEvent::HandleEvent [d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp, line 162] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 524] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 1072] nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 425] main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1303] main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1613] WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1631] WinMainCRTStartup() KERNEL32.DLL + 0x17d08 (0x77e97d08)
I don't see it either in my debug win2k build.
This is almost certainly caused by hyatt's checking to change LocateInstance. realElement is probably nsnull, thus the crash on realElement->SetAttribute(). Hyatt's last change added a parameter to LocateElement() on line 644, which is where realElement is gotten, and there never has been a check to see if an element was actually returned. ->hyatt
Assignee: naving → hyatt
Severity: major → critical
I'm seeing this with aug15 commercial trunk build win98, but only when I use Classic skin.
Keywords: nsBranch
Confirmed in that it is repeatable every time; choose classic skin, click on Search->Search Messages. I am using the Linux nightly, build #2001081508. I suggest changing OS field to 'All' David
OS: Windows 2000 → All
Hardware: PC → All
This is a blocker for Search in mailnews.
*** Bug 95881 has been marked as a duplicate of this bug. ***
This is the top not-yet-fixed crash on the trunk according to talkback. Is this a serious enough blocker for Search that it needs to be a smoketest blocker?
Keywords: topcrash
Summary: crash when selecting Search → crash when selecting Search [@ nsXBLPrototypeBinding::AttributeChanged]
Whiteboard: critical for 0.9.4
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.4
Fix is to just wrap the code in a null check. Looking for r/sr.
(diff -w would show the null test change more clearly :-). Why not use continue instead of overindenting the "normal" guts of the loop? /be
There's an iterative step (2 lines) at the end of the loop.
Duh, sorry I missed that (too bad you can't use a for loop). sr=brendan anyway. /be
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 96010 has been marked as a duplicate of this bug. ***
OK using classic, modern themes, OK with aug27 commercial trunk builds: win98, mac OS 9.0, linux rh6.2.
Status: RESOLVED → VERIFIED
*** Bug 97429 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
Crash Signature: [@ nsXBLPrototypeBinding::AttributeChanged]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: