Closed
Bug 954227
Opened 10 years ago
Closed 10 years ago
Twitter timeline should have a topic
Categories
(Chat Core :: Twitter, defect)
Chat Core
Twitter
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: clokep, Assigned: clokep)
References
Details
(Whiteboard: [0.3-wanted-final])
Attachments
(1 file, 1 obsolete file)
4.14 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 793 at 2011-05-20 13:10:00 UTC *** Twitter should have a topic and an icon -- my suggestion to flo last night was the topic can be your current tweet and the icon your Twitter avatar. See http://log.bezut.info/instantbird/today#m116 for the conversation.
Updated•10 years ago
|
Whiteboard: [0.3-wanted]
Comment 1•10 years ago
|
||
*** Original post on bio 793 at 2011-05-23 07:25:06 UTC *** http://log.bezut.info/instantbird/110520/#m116
Updated•10 years ago
|
Whiteboard: [0.3-wanted] → [0.3-wanted-beta]
Updated•10 years ago
|
Whiteboard: [0.3-wanted-beta] → [0.3-wanted-final]
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 793 as attmnt 722 at 2011-06-17 01:15:00 UTC *** This patch handles setting the topic from the initial timelines that are received as well as when your own message is received back on the user stream (note that I had about a ~10 second delay before it appeared for me). Since MUCs can't yet have an icon (yet?), I think I'll handle that in a follow up after 0.3. (This patch also adds an ERROR message where there was a TODO comment in twitter.js, I can remove this if necessary, but it's simple.) This also adds a setTopic function to jsProtoHelper since I think it's rather useful (I actually copied it out of JS-IRC).
Attachment #8352464 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 793 as attmnt 723 at 2011-06-17 12:45:00 UTC *** flo made some modifications, which I further modified here. We added a setTopic call into the sendTweet function so the topic is set immediately and now we check inside setTopic to ensure we're not setting the topic and topic setter to the same as it was (this allows us to ignore our tweet that comes back over the stream to us). flo also made find the newest tweet more efficient.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8352464 [details] [diff] [review] v1.0 -- Topic only *** Original change on bio 793 attmnt 722 at 2011-06-17 12:45:12 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352464 -
Attachment is obsolete: true
Attachment #8352464 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Summary: Twitter timeline should have a topic / icon → Twitter timeline should have a topic
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 793 at 2011-06-17 12:52:34 UTC *** See bug 954277 (bio 844) for the Twitter icon idea.
Blocks: 954113
Comment 6•10 years ago
|
||
Comment on attachment 8352465 [details] [diff] [review] v2.0 -- Topic only *** Original change on bio 793 attmnt 723 at 2011-06-17 12:55:46 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352465 -
Flags: review+
Comment 7•10 years ago
|
||
*** Original post on bio 793 at 2011-06-17 17:38:38 UTC *** Fixed: https://hg.instantbird.org/instantbird/rev/1a8af91d9474 Thanks! :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Assignee | ||
Updated•10 years ago
|
Component: Conversation → Twitter
Product: Instantbird → Chat Core
You need to log in
before you can comment on or make changes to this bug.
Description
•