Display the character count while typing a tweet

RESOLVED FIXED in 0.3b1

Status

Instantbird
Conversation
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Details

(Whiteboard: [0.3-wanted-beta])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
*** Original post on bio 812 at 2011-05-30 10:55:00 UTC ***

The official twitter web UI just displayed how many characters can still be typed in the tweet next to the "Tweet" button (when the number of remaining characters is negative, it turns red). I think we could just display that in the status bar of the conversation window, which requires no new string.

Currently when tweeting something that is too long, we send the message anyway and the server sends back an error message, as a result of which this is displayed in the conversation window as a system message:
An error (Status is over 140 characters.) occured while sending: <text of the tweet>.
The user can then copy paste the text of the tweet from that error message and try to shorten it. I think it would be a better user experience if we detected locally that the tweet is too long, refused to send the message (I think throwing in the sendMsg method may be enough, but if we dislike valid code throwing exceptions, we can change the method to return a boolean), and kept the text in the textbox. It would be up to the protocol plugin to display a system message in the conversation explaining the error (but this needs a new localizable string).
(Assignee)

Comment 1

4 years ago
*** Original post on bio 812 at 2011-05-30 10:56:53 UTC ***

Marking wanted-beta for the alternative that needs a new string. If it's not fixed before the beta, it will become wanted-final for adding the character count only.
Blocks: 954113
Whiteboard: [0.3-wanted-beta]
(Assignee)

Comment 2

4 years ago
Created attachment 8352413 [details] [diff] [review]
Patch

*** Original post on bio 812 as attmnt 670 at 2011-05-30 23:49:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
(Assignee)

Updated

4 years ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8352413 [details] [diff] [review]
Patch

*** Original change on bio 812 attmnt 670 at 2011-05-31 00:41:01 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352413 - Flags: review+
*** Original post on bio 812 at 2011-05-31 00:41:42 UTC ***

r+ With adding a comment explaining the magic 200 number. :) (And some bike shedding on IRC about whether to keep it at 200 or not.)
(Assignee)

Comment 5

4 years ago
*** Original post on bio 812 at 2011-05-31 00:43:11 UTC ***

https://hg.instantbird.org/instantbird/rev/146e4bed1809
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.3b1
(Assignee)

Comment 6

4 years ago
*** Original post on bio 812 at 2011-05-31 22:52:06 UTC ***

Follow-up: https://hg.instantbird.org/instantbird/rev/97bc144c4562 - hide the character count when the textbox is empty.
You need to log in before you can comment on or make changes to this bug.