Closed Bug 954285 Opened 10 years ago Closed 10 years ago

Removing the last visible tag of a contact should trigger the "other contacts" group

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: FeuerFliege, Assigned: florian)

Details

(Whiteboard: [1.1-blocking])

Attachments

(1 file)

*** Original post on bio 852 at 2011-06-24 17:57:00 UTC ***

Steps to reproduce:

• Connect a online contact with two or more tags.
• Hide offline contacts (don't know if it's necessary)
• Make sure "Other Contacts" group is not shown
• Mark one of the tags as hidden
• Remove the other visible tags of the contact

What happens:
This online contact disappears.

What should happen:
"Other Contacts" should be visible with this contact.
*** Original post on bio 852 at 2011-06-24 18:01:00 UTC ***

According to flo libpurple puts a contact with no tags into the "Buddies" group. http://log.bezut.info/instantbird/110624/#m692
*** Original post on bio 852 at 2011-06-24 18:05:58 UTC ***

It is not an untagged contact. I is tagged with a not visible tag.
Attached image STR
*** Original post on bio 852 as attmnt 726 at 2011-06-24 18:28:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
*** Original post on bio 852 at 2011-06-24 20:51:42 UTC ***

Looks a lot like a regression from https://hg.instantbird.org/instantbird/rev/2c58800cc437

I believe adding "contact-tag-removed" to the list of observers in blist.js would fix this.
Whiteboard: [1.1-blocking]
*** Original post on bio 852 at 2011-09-16 12:43:56 UTC ***

Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
*** Original post on bio 852 at 2011-09-22 10:54:18 UTC ***

(In reply to comment #4)

> I believe adding "contact-tag-removed" to the list of observers in blist.js
> would fix this.

Unfortunately it's not as easy, as the otherContactsTag object in imContacts.js also observes the "contact-tag-removed" notification to populate its _contacts object; meaning that by the time blist.js receives the notification, _contacts may still be empty.

For my fix for 1.1, I'm taking the solution of delaying the execution of the showOtherContacts method in blist.js, because it's the less regression prone idea I have right now.

A cleaner fix could be to rewrite a part of blist.js so that it always keeps an observer on the otherContactsTag and takes into account the "contact-moved-in" notifications received there.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Target Milestone: --- → 1.1
Version: trunk → 1.0
*** Original post on bio 852 at 2011-09-22 11:01:56 UTC ***

https://hg.instantbird.org/instantbird/rev/c3c112f9a72c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.