Closed Bug 954292 Opened 10 years ago Closed 10 years ago

Add context menu to 'conv-top'

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 859 at 2011-06-27 15:14:00 UTC ***

Tabs currently have a context menu with a 'Show logs' option - it would be nice if the much larger conv-top area (with the buddy nick and the avatar) had such a context menu too. Compare also the corresponding context menu in Pidgin, which also has a useful 'Get info' entry.
*** Original post on bio 859 at 2011-06-27 15:17:41 UTC ***

Probably most (all) of the entries from the tab should also be available in this UI. We should probably also add a buddy switching menu if it's not there.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 859 as attmnt 1724 at 2012-06-30 00:34:00 UTC ***

This is a working WIP for people to test whether this is actually wanted.

The advantage is the much larger click target. The disadvantage is the possible confusion since the tabs for other conversations are just above this large area, and their context menu looks exactly the same, so there is potential for mistakes when clicking inaccurately.
Attachment #8353482 - Flags: feedback?(clokep)
*** Original post on bio 859 at 2012-06-30 13:18:02 UTC ***

Is everything within the menupopup duplicated from somewhere else? I think this is definitely wanted, though.
*** Original post on bio 859 at 2012-06-30 13:48:10 UTC ***

In the WIP it's simply copied from tabbrowser, modified only to adapt to the changed position in the DOM tree.

Have you tried it? I'm not 100% sure it's wanted in the present form, though something like it probably is. The code can be polished once the UI decision is taken...
Attached patch Patch v2 (obsolete) — Splinter Review
*** Original post on bio 859 as attmnt 1725 at 2012-06-30 19:58:00 UTC ***

This is better, I think. The context menu is turned off on "active" conv-top-info elements (ie, the topic when it is editable, the target selector).
Attachment #8353483 - Flags: feedback?(clokep)
Comment on attachment 8353482 [details] [diff] [review]
Patch

*** Original change on bio 859 attmnt 1724 at 2012-06-30 19:58:11 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353482 - Attachment is obsolete: true
Attachment #8353482 - Flags: feedback?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attached patch Patch v3Splinter Review
*** Original post on bio 859 as attmnt 1726 at 2012-06-30 22:05:00 UTC ***

Minus duplication, as I realized that was quite straightforward.
Attachment #8353484 - Flags: feedback?(clokep)
Comment on attachment 8353483 [details] [diff] [review]
Patch v2

*** Original change on bio 859 attmnt 1725 at 2012-06-30 22:05:44 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353483 - Attachment is obsolete: true
Attachment #8353483 - Flags: feedback?(clokep)
Comment on attachment 8353484 [details] [diff] [review]
Patch v3

*** Original change on bio 859 attmnt 1726 at 2012-06-30 22:20:29 UTC ***

Might as well r? now the duplication is gone.
Attachment #8353484 - Flags: feedback?(clokep) → review?(clokep)
Comment on attachment 8353484 [details] [diff] [review]
Patch v3

*** Original change on bio 859 attmnt 1726 at 2012-07-10 01:09:27 UTC ***

This works well and seems reasonable to me.
Attachment #8353484 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
Blocks: 954219
*** Original post on bio 859 at 2012-07-11 16:22:11 UTC ***

flo: why cti.setAttribute("topicContext", "tabContextMenu"); rather than a removeAttribute call similar to the line above?

I just remembered, removeAttribute fails to restore the inherited context menu in this case, because the context attribute on the children will still be set.
*** Original post on bio 859 at 2012-07-14 14:31:46 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/0e113cfc6947 Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.