954326 - Support for twitter entities

Status: RESOLVED FIXED

(Chat Core :: Twitter, enhancement)

Description

[Florian Quèze [:florian]]

*** Original post on bio 893 at 2011-07-04 00:01:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 893 as attmnt 731 at 2011-07-04 00:01:00 UTC ***

I had to touch the OAuth code as it didn't handle the GET parameters yet.

During my limited testing, this code gave the expected results.

It's sad that the search API doesn't return the entities (the streaming API returns them by default and the REST API does it when an additional parameter is provided).

It's also sad that this doesn't resolve all URLs (it only resolves t.co URLs).
The twitter.com website uses an undocumented (private?) https://api.twitter.com/1/urls/resolve.json call to resolve other URLs.

A review would be welcome :).

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8352473 [details] [diff] [review]
Patch

*** Original change on bio 893 attmnt 731 at 2011-07-05 16:04:21 UTC ***

I haven't tried this, but it looks good. My only comment is below, and maybe a comment could be put above the parsing of the entities to explain what str, title, text, href, etc. are?


>diff --git a/purple/purplexpcom/src/twitter.js b/purple/purplexpcom/src/twitter.js
>-    this.writeMessage(name, aTweet.text, flags);
>+    let text = aTweet.text;
I think I would prefer to see this defined closer to where it is used.

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch v2

*** Original post on bio 893 as attmnt 733 at 2011-07-05 18:13:00 UTC ***

Same patch but more readable and with an additional comment.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8352473 [details] [diff] [review]
Patch

*** Original change on bio 893 attmnt 731 at 2011-07-05 18:13:43 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8352475 [details] [diff] [review]
Patch v2

*** Original change on bio 893 attmnt 733 at 2011-07-05 19:17:54 UTC ***

r=me, just tested this and it works well. Thanks for clarifying the parts of each entity!

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 893 at 2011-07-07 19:59:04 UTC ***

https://hg.instantbird.org/instantbird/rev/605bc38efc13