Closed
Bug 954335
Opened 10 years ago
Closed 10 years ago
Could not read chrome manifest file '[...]\extensions\{972ce4c6-7e08-4474-a285-3208198ce6fd}\chrome.manifest'
Categories
(Instantbird Graveyard :: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: benediktp, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
2.28 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 902 at 2011-07-09 06:56:00 UTC *** This is the manifest file of the default theme. This problem was reported in bug 954318 (bio 885) comment 0.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 902 as attmnt 798 at 2011-08-31 00:30:00 UTC *** Based on http://mxr.mozilla.org/comm-central/source/mail/themes/qute/Makefile.in this adds a blank chrome.manifest to get rid of the warning.
Attachment #8352540 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8352540 [details] [diff] [review] The fix *** Original change on bio 902 attmnt 798 at 2011-08-31 00:47:52 UTC *** For comparison with Thunderbird: Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=654672 Attachment: https://bugzilla.mozilla.org/attachment.cgi?id=530434&action=diff Changeset: http://hg.mozilla.org/comm-central/rev/11953f14423a It seems you missed the package-manifest.in change. >diff --git a/instantbird/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/Makefile.in >-libs:: >+libs:: $(FILES) > $(PYTHON) $(MOZILLA_SRCDIR)/config/Preprocessor.py $(DEFINES) $(ACDEFINES) $(srcdir)/install.rdf.in > install.rdf >- $(INSTALL) $(FILES) $(DIST)/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} >+ $(INSTALL) $(foreach f,$^,"$f") $(DIST)/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} > >-install:: >- $(SYSINSTALL) $(IFLAGS1) $(FILES) $(DESTDIR)$(mozappdir)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} >+install:: $(FILES) >+ $(SYSINSTALL) $(IFLAGS1) $(foreach f,$^,"$f") $(DESTDIR)$(mozappdir)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} I'm not sure of what this is for.
Attachment #8352540 -
Flags: review?(florian) → review-
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 902 at 2011-08-31 01:01:05 UTC *** (In reply to comment #2) > (From update of attachment 8352540 [details] [diff] [review] (bio-attmnt 798) [details]) > It seems you missed the package-manifest.in change. Ah, yes. I've added that. > >diff --git a/instantbird/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/Makefile.in > >-libs:: > >+libs:: $(FILES) > > $(PYTHON) $(MOZILLA_SRCDIR)/config/Preprocessor.py $(DEFINES) $(ACDEFINES) $(srcdir)/install.rdf.in > install.rdf > >- $(INSTALL) $(FILES) $(DIST)/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} > >+ $(INSTALL) $(foreach f,$^,"$f") $(DIST)/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} > > > >-install:: > >- $(SYSINSTALL) $(IFLAGS1) $(FILES) $(DESTDIR)$(mozappdir)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} > >+install:: $(FILES) > >+ $(SYSINSTALL) $(IFLAGS1) $(foreach f,$^,"$f") $(DESTDIR)$(mozappdir)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} > > I'm not sure of what this is for. Without this change, I get: c:/Users/clokep/instantbird2/objdir-ib-release/mozilla/config/nsinstall.exe inst all.rdf chrome.manifest ../../../../../mozilla/dist/bin/extensions/{972ce4c6-7e 08-4474-a285-3208198ce6fd} nsinstall: chrome.manifest: No such file or directory According to nsinstall.c, it should work though: http://mxr.mozilla.org/mozilla-central/source/config/nsinstall.c#92
Comment 4•10 years ago
|
||
*** Original post on bio 902 at 2011-08-31 18:42:29 UTC *** (In reply to comment #3) > > >diff --git a/instantbird/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/Makefile.in > > >-libs:: > > >+libs:: $(FILES) > > > $(PYTHON) $(MOZILLA_SRCDIR)/config/Preprocessor.py $(DEFINES) $(ACDEFINES) $(srcdir)/install.rdf.in > install.rdf > > >- $(INSTALL) $(FILES) $(DIST)/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} > > >+ $(INSTALL) $(foreach f,$^,"$f") $(DIST)/bin/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd} [...] > > > > I'm not sure of what this is for. > Without this change, I get: > > c:/Users/clokep/instantbird2/objdir-ib-release/mozilla/config/nsinstall.exe > inst > all.rdf chrome.manifest > ../../../../../mozilla/dist/bin/extensions/{972ce4c6-7e > 08-4474-a285-3208198ce6fd} > nsinstall: chrome.manifest: No such file or directory Ok, some testing shows that using $^ here expands the path so that both files that are in the src and in the build dir can be found. This change is ok.
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 902 as attmnt 799 at 2011-08-31 21:17:00 UTC *** With the packaging changes.
Attachment #8352541 -
Flags: review?(florian)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8352540 [details] [diff] [review] The fix *** Original change on bio 902 attmnt 798 at 2011-08-31 21:17:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352540 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
Comment on attachment 8352541 [details] [diff] [review] The fix v2 *** Original change on bio 902 attmnt 799 at 2011-09-02 08:52:29 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352541 -
Flags: review?(florian) → review+
Comment 8•10 years ago
|
||
*** Original post on bio 902 at 2011-09-02 12:07:13 UTC *** https://hg.instantbird.org/instantbird/rev/77fc053940ed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•