Closed Bug 954351 Opened 10 years ago Closed 10 years ago

hide "Check for updates" menuitem if update is not possible

Categories

(Instantbird Graveyard :: Other, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: florian)

Details

*** Original post on bio 918 by Wolfgang Rosenauer [:wolfiR] <mozilla AT rosenauer.org> at 2011-07-11 19:19:00 UTC ***

If instantbird is provided as package on a Linux distribution normal users have no write access to the installation directory and mozilla apps are usually built with --disable-updater anyway.
Therefore the menu item to "Check for updates" should be hidden (if it's meant to update the application; and not addons or alike).
Firefox and Thunderbird is doing that for example:

https://mxr.mozilla.org/mozilla1.9.2/source/browser/base/content/baseMenuOverlay.xul#105
or using
https://mxr.mozilla.org/mozilla2.0/source/toolkit/mozapps/update/nsUpdateService.js#205
*** Original post on bio 918 at 2011-07-11 20:27:57 UTC ***

This just needs an ifdef in instantbird/content/menus.xul
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [good first bug]
*** Original post on bio 918 at 2011-07-13 00:12:10 UTC ***

http://hg.instantbird.org/instantbird/rev/57643a5b503d
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → 1.1
You need to log in before you can comment on or make changes to this bug.