954353 - Build failure due to vsnprintf redefinition in purple/libpurple/win32/libc_interface.h

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Instantbot]

*** Original post on bio 920 by Nils Maier [:nmaier] <maierman AT web.de> at 2011-07-12 07:09:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Instantbot]

Attachment: patch v0, remove vsnprintf definitions

*** Original post on bio 920 as attmnt 740 by maierman AT web.de at 2011-07-12 07:09:00 UTC ***

I'm trying to build instantbird tip on Windows 7/MSVC9/MozillaBuild latest, unchanged mozconfig.

The compiler yields an error when trying to compile purple/purplexpcom due to the definition of vsnprintf in purple/libpurple/win32/libc_interface.h


Corresponding log lines:
> ..\VC\INCLUDE\stdio.h(358) : error C3163: '_vsnprintf': attributes inconsistent with previous declaration
> ..\VC\INCLUDE\stdio.h(350) : see declaration of '_vsnprintf'

The attached (but not "cleaned") path seems to resolve this issue, but due to other issues later (unresolved glib) I didn't tackle yet I don't know if the patch is correct nor do I know if it makes other configurations fail...

Comment 2

[Instantbot]

Comment on attachment 8352482 [details] [diff] [review]
patch v0, remove vsnprintf definitions

*** Original change on bio 920 attmnt 740 by maierman AT web.de at 2011-07-12 07:10:10 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 920 at 2011-07-13 00:10:35 UTC ***

I assume there was a reason at some point to add this define, but even with MSVC8 (2005) on which this was created, I can compile fine without these two lines, so I've just removed them in http://hg.instantbird.org/instantbird/rev/57643a5b503d

Thanks for figuring this out and reporting it. I'm almost sure this is the cause of the "inexplicable" build failure at least 2 people before you experienced when building with MSVC > 8.