Closed Bug 954386 Opened 10 years ago Closed 10 years ago

Account list has useless 5px padding above first item

Categories

(Instantbird Graveyard :: Account manager, enhancement)

All
Windows 7
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: Mook)

Details

Attachments

(3 files)

*** Original post on bio 952 by Mook <mook.moz+bugs.instantbird AT gmail.com> at 2011-07-29 04:33:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch remove top barSplinter Review
*** Original post on bio 952 as attmnt 759 by mook.moz+bugs.instantbird AT gmail.com at 2011-07-29 04:33:00 UTC ***

The accounts window, on Vista/Win7 only, has a 5px padding above the first element in order to fit the rounded corners at the top.

The attached patch removes the top padding and puts it on the children instead (sort of).  Only #accountsNotificationBox gets a new background color because #noAccountScreen has already got one.
Comment on attachment 8352501 [details] [diff] [review]
remove top bar

*** Original change on bio 952 attmnt 759 by mook.moz+bugs.instantbird AT gmail.com at 2011-07-29 04:34:49 UTC ***

I can't seem to find Mic's bugmail, so clokep, you get to look instead ;)
Attachment #8352501 - Attachment is patch: true
Attachment #8352501 - Attachment mime type: application/octet-stream → text/plain
Attachment #8352501 - Flags: review?(clokep)
*** Original post on bio 952 as attmnt 760 at 2011-07-29 10:23:00 UTC ***

The new look of the account manager, with it selected.
*** Original post on bio 952 as attmnt 761 at 2011-07-29 10:35:00 UTC ***

With notification bar.
Comment on attachment 8352501 [details] [diff] [review]
remove top bar

*** Original change on bio 952 attmnt 759 at 2011-07-29 10:36:58 UTC ***

This looks fine to me, I put up some images so other people don't necessarily have to apply the patches.
Attachment #8352501 - Flags: review?(clokep) → review+
*** Original post on bio 952 at 2011-07-29 10:37:27 UTC ***

Assigning to Mook.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
*** Original post on bio 952 at 2011-08-01 21:13:19 UTC ***

> 20:22:47 <flo> Has Mic seen bug 954386 (bio 952)?

Yes, I've seen it and I really think that it is an improvement over the old look. It looks much more like made 'of one piece' now :)

Strictly speaking I haven't applied the patch myself but I moved the styles to my userChrome.css and it looks as expected.

One more thing: I checked the look of the "No accounts are configured yet"-message and it is also fine.

Thanks for the patch!
*** Original post on bio 952 at 2011-08-31 00:34:38 UTC ***

https://hg.instantbird.org/instantbird/rev/2ae3a895c9fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1
Assignee: bugzilla → mook.moz+mozbz
You need to log in before you can comment on or make changes to this bug.