Closed Bug 954413 Opened 10 years ago Closed 10 years ago

Fix look for "Hidden conversations" /"Contacts" contact list sections and their headers

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: benediktp)

References

Details

(Whiteboard: [1.1-wanted])

Attachments

(4 files, 2 obsolete files)

*** Original post on bio 979 at 2011-08-24 11:33:00 UTC ***

A few things:

* The hidden conversation list has differently aligned icons and labels than the contact list.

* The section headers look awful. Should this depend on bug 954407 (bio 973) if the latter would be accepted as a welcome change?
Blocks: 954412
*** Original post on bio 979 as attmnt 786 at 2011-08-24 12:11:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8352528 [details]
Screenshot on Windows ("Hidden conversation" section header is hovered, mouse pointer not visible)

*** Original change on bio 979 attmnt 786 at 2011-08-24 12:28:05 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352528 - Attachment description: Screenshot on Windows → Screenshot on Windows ("Hidden conversation" section header is hovered, mouse pointer not visible)
*** Original post on bio 979 at 2011-08-25 14:17:42 UTC ***

* The bottom pixels of the unread counters are cut off (not displayed), on Linux at least
Attached image Unread counter on Linux
*** Original post on bio 979 as attmnt 788 at 2011-08-25 15:10:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
*** Original post on bio 979 at 2011-08-26 17:51:17 UTC ***

I think a border around each set (i.e. the title "Conversations" and the conversation list and a separate border around "Contacts" and the contact list) would help to group them better and might make the headers look less out of place.
*** Original post on bio 979 at 2011-08-30 15:25:59 UTC ***

(In reply to comment #2)
> * The bottom pixels of the unread counters are cut off (not displayed), on
> Linux at least

This was addressed by https://hg.instantbird.org/instantbird/rev/bc7139549f4f
*** Original post on bio 979 at 2011-08-31 00:32:26 UTC ***

(In reply to comment #0)

> * The hidden conversation list has differently aligned icons and labels than
> the contact list.
Fixed in https://hg.instantbird.org/instantbird/rev/e99bb424fdfc
Whiteboard: [1.1-wanted]
*** Original post on bio 979 at 2011-09-27 22:41:20 UTC ***

(In reply to comment #0)

> * The section headers look awful.

https://hg.instantbird.org/instantbird/rev/9b9834f033a8 fixes this at least on Mac. At least another patch will be needed for WinAero (both with and without glass).
Attached image Screenshot of Aero - Patch v1 (obsolete) —
*** Original post on bio 979 as attmnt 854 at 2011-09-29 18:02:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attached patch Aero - Patch v1 (obsolete) — Splinter Review
*** Original post on bio 979 as attmnt 855 at 2011-09-29 18:05:00 UTC ***

I'm attaching the few things that I already changed the other day. The borders of the listheaders need some work imo, but I've got no time to do that tonight.
Attached patch Aero - Patch v3Splinter Review
*** Original post on bio 979 as attmnt 879 at 2011-10-12 18:34:00 UTC ***

Here's what I have for this so far. I tried touching existing CSS as little as possible and added almost all changes in blist-aero.css

Don't be confused by "v3", "v2" of the patch was just never uploaded to Bugzilla;)
Attachment #8352622 - Flags: review?(florian)
*** Original post on bio 979 as attmnt 880 at 2011-10-12 18:36:00 UTC ***

Here's what it looks like when attachment 8352622 [details] [diff] [review] (bio-attmnt 879) is applied.
Comment on attachment 8352597 [details]
Screenshot of Aero - Patch v1

*** Original change on bio 979 attmnt 854 at 2011-10-12 18:36:30 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352597 - Attachment is obsolete: true
Comment on attachment 8352598 [details] [diff] [review]
Aero - Patch v1

*** Original change on bio 979 attmnt 855 at 2011-10-12 18:36:30 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352598 - Attachment is obsolete: true
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Comment on attachment 8352622 [details] [diff] [review]
Aero - Patch v3

*** Original change on bio 979 attmnt 879 at 2011-10-12 18:42:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352622 - Attachment is patch: true
Attachment #8352622 - Attachment mime type: application/octet-stream → text/plain
*** Original post on bio 979 at 2011-10-12 20:48:16 UTC ***

Some or all of those changes might also look good on Linux (where currently there are too many borders in the buddy list window, just as there used to be for Windows)
Comment on attachment 8352622 [details] [diff] [review]
Aero - Patch v3

*** Original change on bio 979 attmnt 879 at 2011-10-12 21:08:55 UTC ***

>diff -r 549c2079e180 instantbird/themes/blist-aero.css

>+    background-image: -moz-linear-gradient(rgba(0,0,0,0), rgba(0,0,0,0.05));

Coding style nit: a space after each comma.
(I'm fixing this before pushing, don't worry about it).

Thanks for working on this! :-)
Attachment #8352622 - Flags: review?(florian) → review+
*** Original post on bio 979 at 2011-10-12 21:14:46 UTC ***

Pushed attachment 8352622 [details] [diff] [review] (bio-attmnt 879) as https://hg.instantbird.org/instantbird/rev/07440638cc63

These section headers may still need some work on Linux, but we aren't waiting on that for the 1.1 release, so I'm resolving this as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1
You need to log in before you can comment on or make changes to this bug.