Closed
Bug 954420
Opened 10 years ago
Closed 10 years ago
Improve theming of the "unread count"
Categories
(Instantbird Graveyard :: Contacts window, defect)
Instantbird Graveyard
Contacts window
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: benediktp, Assigned: benediktp)
References
Details
(Whiteboard: [1.1-nice-to-have])
Attachments
(3 files)
*** Original post on bio 986 at 2011-08-24 15:12:00 UTC *** 17:05:07 - flo: the unread count will definitely need OS specific theming 17:05:35 - flo: on Mac I would like to attempt to imitate iTunes's apps with updates count number
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 986 at 2011-08-31 12:39:45 UTC *** I think the styling should change when hovering the number since the unread count is interactive now (a single click shows the conversation). I can definitely take the Windows styling and I'd try to find something for Mac and Linux too if someone can get me recent screenshots. I think we should agree only the colors for notifications first, see bug 954234 (bio 800).
Updated•10 years ago
|
Whiteboard: [1.1-nice-to-have]
Comment 2•10 years ago
|
||
*** Original post on bio 986 as attmnt 844 at 2011-09-23 22:03:00 UTC *** (In reply to comment #0) > 17:05:35 - flo: on Mac I would like to attempt to imitate iTunes's apps with > updates count number Let me show a screenshot to clarify what I was talking about.
Comment 3•10 years ago
|
||
*** Original post on bio 986 at 2011-09-27 10:27:52 UTC *** Actually, on Mac it already looks like what I wanted (that is, the iTunes update count) minus the color. The color currently matches the tab colors. Even if the color used is not great, at least it's consistent across the application. So I would say no change is needed on Mac. I haven't checked recently, but I think on Linux it looks acceptable, especially after the font-size and margin changes from https://hg.instantbird.org/instantbird/rev/bc7139549f4f. About the change on hover to reflect the possible interaction, while it may be beautiful, I don't think it's actually needed (for 1.1) as the mouse pointer already changes for that. I don't remember how it looks on Windows / if it was horrible. If someone cares about this being addressed for 1.1, work here should start soon.
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 986 as attmnt 869 at 2011-10-09 19:41:00 UTC *** This patch changes the color of the text and the background-color of the unread counters.
Attachment #8352612 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 986 as attmnt 870 at 2011-10-09 19:42:00 UTC *** Screenshot of what the counters look like with the patch applied.
Comment 6•10 years ago
|
||
Comment on attachment 8352612 [details] [diff] [review] Patch v1 *** Original change on bio 986 attmnt 869 at 2011-10-09 20:23:15 UTC *** Ok, let's take that on nightlies to see which feedback we get. :-)
Attachment #8352612 -
Flags: review?(florian) → review+
Comment 7•10 years ago
|
||
*** Original post on bio 986 at 2011-10-09 21:14:24 UTC *** Comment on attachment 8352612 [details] [diff] [review] (bio-attmnt 869) Patch v1 Pushed as https://hg.instantbird.org/instantbird/rev/cc60b3d4e6b3
Comment 8•10 years ago
|
||
*** Original post on bio 986 at 2011-10-12 16:20:52 UTC *** The feedback I've seen has been either slightly positive or neutral (people were more concerned with the SSL issue caused by a check-in the same day), so I think we will keep attachment 8352612 [details] [diff] [review] (bio-attmnt 869) and resolve this as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: OS specific theming for "unread count" → Improve theming of the "unread count"
Target Milestone: --- → 1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•