Closed
Bug 954435
Opened 10 years ago
Closed 10 years ago
New messages merge with existing context bubbles
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: clokep, Assigned: florian)
References
Details
(Whiteboard: [1.1-wanted])
*** Original post on bio 1001 at 2011-08-30 01:34:00 UTC *** From bug 954427 (bio 993): (In reply to comment #4) > (In reply to comment #3) > > There is still an edge case that doesn't work: when the new message becomes > > part of an existing speech bubble, desaturation is applied. > > This isn't easy enough to fix that I could do it right now in 5 minutes or so. > If we don't want to forget about this, a new bug for this issue would be a good > idea.
Comment 1•10 years ago
|
||
*** Original post on bio 1001 at 2011-08-30 08:44:43 UTC *** appended from IRC: 20:24:14 <flo> aleth: would splitting that bubble into 2 separate bubbles be a good fix for the issue? (mentioned in bug 954427 (bio 993) comment 3) 21:26:10 <aleth> flo: sure - that sounds good. 21:26:44 <flo> wouldn't it looks odd that when closing the conversation tab and reopening it the 2 messages would then be in the same bubble again? 21:58:49 <aleth> flo: depends on how good your visual memory is I suppose ;) 21:59:21 <aleth> Actually I was going to suggest an additional horizontal line between the already-read and the unread messages 21:59:37 <aleth> This would provide an additional visual marker, and be clearly temporary at the same time 21:59:55 <aleth> So it would be "obvious" what is cutting the bubble in two 22:17:22 <aleth> (You might also want this line in tabs that don't have focus for consistency)
Comment 2•10 years ago
|
||
*** Original post on bio 1001 at 2011-08-30 10:33:32 UTC *** The wrong colored bubble only makes it obvious that the message is merged into a bubble marked as 'context'. Summary is fixed now. (In reply to comment #1) > 20:24:14 <flo> aleth: would splitting that bubble into 2 separate bubbles be a > good fix for the issue? (mentioned in bug 954427 (bio 993) comment 3) > 21:26:10 <aleth> flo: sure - that sounds good. > 21:26:44 <flo> wouldn't it looks odd that when closing the conversation tab and > reopening it the 2 messages would then be in the same bubble again? > 21:58:49 <aleth> flo: depends on how good your visual memory is I suppose ;) > 21:59:21 <aleth> Actually I was going to suggest an additional horizontal line > between the already-read and the unread messages The "separate as long as there's a separator"-idea sounds good.
Summary: New messages merge with existed desaturated bubbles → New messages merge with existing context bubbles
Comment 3•10 years ago
|
||
*** Original post on bio 1001 at 2011-09-09 18:53:55 UTC *** Splitting the bubble into two separate bubbles seems like a necessary thing to do, whatever one later decides about a possible additional separator. Depending on the message style and its degree of visual distinction between context and normal messages, this might be all that is required.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.1-wanted]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1001 at 2011-09-23 22:16:58 UTC *** https://hg.instantbird.org/instantbird/rev/33ad74c11b8c This will split the bubble. While I'm not really satisfied with this patch (it's a bit hackish), I think it's good enough for 1.1.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•