954456 - Replace unsupported libpurple QQ with libqq-pidgin

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Instantbot]

*** Original post on bio 1021 by Matt Lewandowsky (lewellyn) <matt AT greenviolet.net> at 2011-09-06 18:19:00 UTC ***

As upstream has ceased support of their QQ protocol implementation, and it is known to be broken, it seems wise to rebase upon a supported implementation.

The implementation currently most active is libqq-pidgin <http://code.google.com/p/libqq-pidgin/>.

It, however, does not compile trivially with Instantbird at this time.

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1021 at 2011-09-06 18:46:34 UTC ***

Just wanted to say that we'd really like this for our next release (1.1) due out in September, thanks for taking a look at this!

Also a diff of the current QQ plug-in to libpurple 2.7.9 (to see what changes we've made: note that they're mostly MSVC compatibility changes, although the WINCE ones are unnecessary now). http://pastebin.instantbird.com/936

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1021 at 2011-09-27 10:31:13 UTC ***

We really want this, but I'm afraid it's too late for 1.1 already :-(.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: libqq in Instantbird v1.0

*** Original post on bio 1021 as attmnt 850 at 2011-09-27 21:47:00 UTC ***

This takes the tip of the libqq repo (rev 195) and applies it to Instantbird with some patches.  This also adds gdate from glib. Diff from libqq up next.

Comment 4

[Patrick Cloke [:clokep]]

Attachment: libqq in Instantbird v1.1

*** Original post on bio 1021 as attmnt 851 at 2011-09-28 15:44:00 UTC ***

This is a cleaner patch with white space changes removed. After email conversing with the author of libqq, he suggests using the tip of SVN (so this is based off the proper revision).

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8352593 [details] [diff] [review]
libqq in Instantbird v1.0

*** Original change on bio 1021 attmnt 850 at 2011-09-28 15:44:11 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Patrick Cloke [:clokep]]

Attachment: diff from libqq r195

*** Original post on bio 1021 as attmnt 852 at 2011-09-28 15:45:00 UTC ***

This is a diff of what I've changed to get this to compile with MSVC.  It still has some warnings, but I'm unsure whether they are dangerous or not as I have no QQ account to test. Perhaps lewellyn can help with testing?

Comment 7

[Florian Quèze [:florian]]

Attachment: libqq in Instantbird v1.2

*** Original post on bio 1021 as attmnt 853 at 2011-09-28 22:25:00 UTC ***

Some more changes:
 b/purple/libpurple/protocols/qq/buddy_opt.c |    4 -
  replace the call to g_strcmp0 by a purple_strequal call.

 purple/libpurple/purple-prefs.js            |    2 
  update the default value of a pref to reflect a change in the code.

 purple/libraries/glib/glib.symbols          |    2 
  remove an #if 0 around the symbols of gdate

 purple/locales/en-US/qq.properties          |   66 +++++++++++-----------------
  update the translation file

 purple/upgrade-libpurple.sh                 |    1 
  remove an obsolete line.

I pushed this patch minus the translation changes as https://hg.instantbird.org/instantbird/rev/8d29e9fbe26f

I'll push the translation changes if after some nightly testing we determine that this change is an improvement over the current situation of the QQ prpl.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8352594 [details] [diff] [review]
libqq in Instantbird v1.1

*** Original change on bio 1021 attmnt 851 at 2011-09-28 22:25:51 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 9

[Florian Quèze [:florian]]

Attachment: L10n changes that I haven't pushed

*** Original post on bio 1021 as attmnt 868 at 2011-10-07 11:01:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[Patrick Cloke [:clokep]]

*** Original post on bio 1021 at 2011-12-11 00:05:03 UTC ***

I filed a bug at libqq to upstream the MSVC changes: https://code.google.com/p/libqq-pidgin/issues/detail?id=219

Comment 11

[Patrick Cloke [:clokep]]

*** Original post on bio 1021 at 2012-05-08 12:32:46 UTC ***

(In reply to comment #6)
> Created attachment 8352596 [details] [diff] [review] (bio-attmnt 853) [details]
[...]
> I'll push the translation changes if after some nightly testing we determine
> that this change is an improvement over the current situation of the QQ prpl.

We had a report recently [1] that QQ is working. I think we should push the l10n changes. This way it'll be fully up to date and we could always disable it in the makefile, as well. Hopefully I can get around to fix bug 954015 (bio 578) and then QQ should work fine.

Unfortunately there haven't been any updates since June 11, 2011 at upstream, however. :(

[1] http://blog.instantbird.org/2012/02/status-update-february-25-2012/comment-page-1/#comment-1280

Comment 12

[Patrick Cloke [:clokep]]

*** Original post on bio 1021 at 2012-06-10 21:04:55 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/74d6f034e992

Comment 13

[Florian Quèze [:florian]]

*** Original post on bio 1021 at 2012-06-10 21:05:54 UTC ***

(In reply to comment #10)
> Checked in as http://hg.instantbird.org/instantbird/rev/74d6f034e992

This check-in is only an update to the en-US version of qq.properties.