Closed
Bug 954461
Opened 10 years ago
Closed 10 years ago
Email addresses are filtered out of conversations content
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file)
500 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1026 at 2011-09-09 21:50:00 UTC *** Currently email addresses are highlighted, but have no context menu. "Copy email address" would be useful.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1026 at 2011-09-10 19:38:21 UTC *** Turns out email addresses are currently not highlighted in all message styles. In particular the default bubbles style does not feature it, while minimal 2 does. What is required in main.css is a section such as a{ border-bottom: 1px dashed; text-decoration: none; } a:hover{ border-bottom: 1px solid; } This will then also apply to URLs afaik.
Comment 2•10 years ago
|
||
*** Original post on bio 1026 at 2011-09-10 20:34:07 UTC *** - A "Copy email address" context menu item does exist. - Underlining on <a> tags that don't have an href attribute is a bug in the minimal 2 theme. - The real issue here is that imContentSink filters out mailto link. I think someone interested in fixing this would just have to edit the kAllowedURLs regexp at http://lxr.instantbird.org/instantbird/source/instantbird/modules/imContentSink.jsm#78 and verify that it fixes the bug.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hardware: x86 → All
Summary: Context menu for email addresses in conversations → Email addresses are filtered out of conversations content
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1026 as attmnt 811 at 2011-09-10 20:57:00 UTC *** Seems to work ;)
Comment 4•10 years ago
|
||
Comment on attachment 8352553 [details] [diff] [review] Patch *** Original change on bio 1026 attmnt 811 at 2011-09-10 21:47:23 UTC *** You probably want to request a review on this. :)
Attachment #8352553 -
Flags: review?
Comment 5•10 years ago
|
||
Comment on attachment 8352553 [details] [diff] [review] Patch *** Original change on bio 1026 attmnt 811 at 2011-09-13 18:05:09 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352553 -
Flags: review? → review+
Comment 6•10 years ago
|
||
*** Original post on bio 1026 at 2011-09-13 18:07:38 UTC *** aleth, would you like me to use your real name (which I don't know) for pushing this patch?
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Target Milestone: --- → 1.1
Assignee | ||
Comment 7•10 years ago
|
||
*** Original post on bio 1026 at 2011-09-13 18:54:58 UTC *** No, that's alright, I'll save that for when I contribute something a little bigger :)
Assignee | ||
Comment 8•10 years ago
|
||
*** Original post on bio 1026 at 2011-09-29 11:21:49 UTC *** Fixed with https://hg.instantbird.org/instantbird/rev/d936dfe24df0, I believe.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•