Closed Bug 954477 Opened 7 years ago Closed 7 years ago

Credits in About-dialog only taking up a small fraction of the available space

Categories

(Instantbird :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: florian)

Details

(Whiteboard: [1.1-blocking])

Attachments

(1 file)

*** Original post on bio 1042 at 2011-09-16 14:54:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached image Screenshot
*** Original post on bio 1042 as attmnt 829 at 2011-09-16 14:54:00 UTC ***

The credits in About-dialog only taking up a small fraction of the available space. See the attached screenshot.


16:51:25 - flo: uh, that's ugly :(
16:51:35 - flo: probably a missing flex attributebly a missing flex attribute
Whiteboard: [1.1-blocking]
*** Original post on bio 1042 at 2011-09-16 14:58:40 UTC ***

flo's quote actually read:

16:51:25 - flo: uh, that's ugly :(
16:51:35 - flo: probably a missing flex attribute
16:51:52 - flo: that bug probably deserves a blocker bonus too ;)
*** Original post on bio 1042 at 2011-09-22 11:01:45 UTC ***

https://hg.instantbird.org/instantbird/rev/ebe79a2e9043

So it turns out the flex attribute was there, but not taken into account because it's a XUL attribute and the tab had an HTML namespace. I don't see why that namespace was used, as the iframe element also exists in XUL. XUL iframe defaults to no border, so I removed the style="border: 0px" attribute too.
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1
You need to log in before you can comment on or make changes to this bug.