Closed
Bug 954479
Opened 10 years ago
Closed 10 years ago
Linked tags starting with ›#‹ don't work
Categories
(Chat Core :: Twitter, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: FeuerFliege, Assigned: FeuerFliege)
Details
Attachments
(1 file)
637 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1045 at 2011-09-19 17:54:00 UTC *** Twitter tags are linked, but for tags starting with ›#‹ they won't work. The ›#‹ should be replaced by ›%23‹. Example: Tag: #instantbird Generated link (not working): https://twitter.com/#!/search?q=#instantbird link that should work: https://twitter.com/#%21/search?q=%23instantbird
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1045 at 2011-09-19 18:00:20 UTC *** possible fix(?): Change <http://hg.instantbird.org/instantbird/file/16877232760e/purple/purplexpcom/src/twitter.js#l202> href: "https://twitter.com/#!/search?q=#" + h.text}))); to href: "https://twitter.com/#!/search?q=%23" + h.text})));
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1045 as attmnt 836 at 2011-09-20 17:20:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment 3•10 years ago
|
||
Comment on attachment 8352579 [details] [diff] [review] replaced # from tag with %23. WFM *** Original change on bio 1045 attmnt 836 at 2011-09-22 11:03:47 UTC *** Looks OK! :-)
Attachment #8352579 -
Flags: review+
Comment 4•10 years ago
|
||
*** Original post on bio 1045 at 2011-09-22 11:04:52 UTC *** I still haven't been able to reproduce the issue on Mac OS, but it has been confirmed by several people on IRC, and it works for me either with the # or the %23 in the URL, so I think we should take this for 1.1. Thanks for reporting/patching this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•10 years ago
|
||
*** Original post on bio 1045 at 2011-09-22 22:51:04 UTC *** https://hg.instantbird.org/instantbird/rev/4653f6705fd2
Assignee: nobody → bug
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•