Closed
Bug 954485
Opened 10 years ago
Closed 10 years ago
Sort hidden conversations
Categories
(Instantbird Graveyard :: Contacts window, enhancement)
Instantbird Graveyard
Contacts window
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [1.1-wanted])
Attachments
(1 file)
1.81 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1051 at 2011-09-27 11:03:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1051 as attmnt 848 at 2011-09-27 11:03:00 UTC *** The attached patch sorts the list of conversations. - Given that the list of conversations is typically small, I don't think it's worth implementing a binary search for the position here. (Am I wrong here? If someone wants to do it in a follow up that's welcome I guess :-)) - If the title of a conversation changes, its position won't be updated (and subsequently added conversations may be misplaced). While this is obviously a bug, I don't think I care for 1.1. My goal here (for 1.1) is essentially to give some sort of stability in the ordering of the list, so that showing a conversation and hiding it again puts it back at the same place in the list, most of the time.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.1-wanted]
Comment 2•10 years ago
|
||
Comment on attachment 8352591 [details] [diff] [review] Patch *** Original change on bio 1051 attmnt 848 at 2011-09-27 19:44:25 UTC *** This looks good, my only comment was to possibly make a function out of the comparisons (like bug 954206 (bio 772)). Flo said he'd accept a patch, but isn't interested in doing that. I'm OK w/ that.
Attachment #8352591 -
Flags: review+
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1051 at 2011-09-27 22:43:30 UTC *** https://hg.instantbird.org/instantbird/rev/55aed291f827
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•