954495 - Suggestion: Remove dividing line from info area in buddy list and conversation

Status: RESOLVED INVALID

(Instantbird Graveyard :: Other, enhancement)

Description

[aleth [:aleth]]

*** Original post on bio 1059 at 2011-10-04 20:45:00 UTC ***

Not a bug, but a suggestion for discussion: I tend to think the buddy list and conversation window look better (because marginally less busy) with the dividing line between display name and status removed.

Comment 1

[aleth [:aleth]]

Attachment: Patch for Conversation window

*** Original post on bio 1059 as attmnt 860 at 2011-10-04 20:46:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 2

[aleth [:aleth]]

Attachment: Patch for buddy list

*** Original post on bio 1059 as attmnt 861 at 2011-10-04 20:46:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[aleth [:aleth]]

*** Original post on bio 1059 at 2011-10-04 20:49:09 UTC ***

(Buddy list patch also adjusts the text positioning a little, as a consequence of the extra space)

Comment 4

[aleth [:aleth]]

*** Original post on bio 1059 at 2011-10-04 22:06:43 UTC ***

I think the reason the line is too much (at least on Linux) is because e.g. in the conversation window it leads to there being 4 horizontal lines of one kind or another underneath each other at the top of the window - with roughly equal vertical spacing. This spoils the visual solidity of the tab.

Comment 5

[aleth [:aleth]]

Attachment: Normal chat conversation top comparison

*** Original post on bio 1059 as attmnt 863 at 2011-10-04 22:55:00 UTC ***

(Linux/KDE4)

Comment 6

[aleth [:aleth]]

Attachment: MUC and buddy list comparison screenshot

*** Original post on bio 1059 as attmnt 864 at 2011-10-04 22:59:00 UTC ***

Linux/KDE4 and Linux/Gnome2. Status quo displayed in the middle. Note the changes include the patches in this bug as well as those in bug 954494 (bio 1058) and bug 954496 (bio 1060), as well as the modification described in the following patch.

Comment 7

[aleth [:aleth]]

Attachment: Additional patch for conversation.css

*** Original post on bio 1059 as attmnt 865 at 2011-10-04 23:00:00 UTC ***

This patch removes the border on the right and on the bottom of the message area (for a cleaner look and consistency with the buddy list).

Comment 8

[aleth [:aleth]]

*** Original post on bio 1059 at 2011-10-05 09:21:23 UTC ***

I guess that's all for now...

Comment 9

[aleth [:aleth]]

Comment on attachment 8352608 [details] [diff] [review]
Additional patch for conversation.css

*** Original change on bio 1059 attmnt 865 at 2011-10-05 09:23:22 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[aleth [:aleth]]

Comment on attachment 8352604 [details] [diff] [review]
Patch for buddy list

*** Original change on bio 1059 attmnt 861 at 2011-10-05 09:23:38 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 11

[aleth [:aleth]]

Comment on attachment 8352603 [details] [diff] [review]
Patch for Conversation window

*** Original change on bio 1059 attmnt 860 at 2011-10-05 09:23:52 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 12

[aleth [:aleth]]

*** Original post on bio 1059 at 2011-10-10 17:45:43 UTC ***

(In reply to comment #7)
> Created an attachment (id=865) [details]
> Additional patch for conversation.css

Separated out to bug 954500 (bio 1065) as it's an independent issue.

Comment 13

[Florian Quèze [:florian]]

Comment on attachment 8352608 [details] [diff] [review]
Additional patch for conversation.css

*** Original change on bio 1059 attmnt 865 at 2011-10-15 23:01:19 UTC ***

Per comment 9, this doesn't belong to this bug.

Comment 14

[Florian Quèze [:florian]]

Comment on attachment 8352603 [details] [diff] [review]
Patch for Conversation window

*** Original change on bio 1059 attmnt 860 at 2011-10-15 23:07:42 UTC ***

I asked around a bit and showed the screenshot. People seem to like the UI as well with or without the line.

I quite like it, and I think it's part of what gives Instantbird a distinct appearance from other IM clients (a bit like the keyhole shape for the Firefox toolbar, see http://blog.mozilla.com/faaborg/2008/01/17/keyhole-coming-to-os-x-and-windows-themes/ if you have no idea of what I'm talking about with this keyhole :-)), so I would rather keep it.

And yes, I know this is probably a disappointing answer for you; however I would like to thank you (again?) for trying hard to make Instantbird look as good as possible on your OS. Thanks! :-)

Comment 15

[Florian Quèze [:florian]]

Comment on attachment 8352604 [details] [diff] [review]
Patch for buddy list

*** Original change on bio 1059 attmnt 861 at 2011-10-15 23:08:16 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 16

[Florian Quèze [:florian]]

*** Original post on bio 1059 at 2011-10-15 23:09:33 UTC ***

Resolving as invalid (no offense intended, even though that term seems a bit rude :-/) per comment 11.