954501 - Collapsing contact info in buddy list with mouse will hide the contact

Status: RESOLVED FIXED

(Instantbird Graveyard :: Contacts window, defect)

Description

[Florian J. [:FeuerFliege]]

*** Original post on bio 1066 at 2011-10-11 13:03:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian J. [:FeuerFliege]]

Attachment: click circled button, contact will be hidden

*** Original post on bio 1066 as attmnt 873 at 2011-10-11 13:03:00 UTC ***

Open detailed contact information (right cursor) and collaspe the info with the mouse (not keyboard!) again.

Expected: only info disappears
Actual result: contact gets hidden

Instantbird version:  1.1a1pre (20111011092429)

Flo said via IRC hat he couldn't reproduce, can anybody reproduce?

Comment 2

[Instantbot]

Attachment: Invisible Contacts

*** Original post on bio 1066 as attmnt 874 by mattdentremont AT gmail.com at 2011-10-11 14:21:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1066 at 2011-10-11 14:28:12 UTC ***

Need to investigate this before shipping :(

Comment 4

[Benedikt Pfeifer]

*** Original post on bio 1066 at 2011-10-11 14:36:27 UTC ***

I'm seeing this (no pun intended) with 20111011092429 on Windows 7.

Comment 5

[Florian J. [:FeuerFliege]]

*** Original post on bio 1066 at 2011-10-12 08:24:42 UTC ***

You cannot expand the contact info by using the mouse, maybe that is connected.

When you try to expand the list, the line with the expand arrow will disappear.

Comment 6

[Florian J. [:FeuerFliege]]

*** Original post on bio 1066 at 2011-10-12 08:40:36 UTC ***

It is a regession:

last good: version 1.1a1pre (20110921041646)
first bad: version 1.1a1pre (20110922041631)

Comment 7

[Florian J. [:FeuerFliege]]

*** Original post on bio 1066 at 2011-10-12 08:41:09 UTC ***

It is a regression:

last good: version 1.1a1pre (20110921041646)
first bad: version 1.1a1pre (20110922041631)

Comment 8

[Florian Quèze [:florian]]

*** Original post on bio 1066 at 2011-10-12 09:05:22 UTC ***

In that range it's likely from https://hg.instantbird.org/instantbird/rev/74d6a3f1d658

Comment 9

[Florian J. [:FeuerFliege]]

*** Original post on bio 1066 at 2011-10-12 09:31:05 UTC ***

This lines are causing the regression:
http://hg.instantbird.org/instantbird/rev/74d6a3f1d658#l1.7

It seems the buddylistbox does not get the focus, when the expand/collapse button is pressed by mouse.

This bug can be fixed by rechangeing the "#buddylistbox:focus > contact[selected]" to "contact[selected]" but of cause the intended appearence will be changed.


You can see the difference by adding the following lines to chrome/userChrome.css:


contact[selected] {
    -moz-binding: url("chrome://instantbird/content/contact.xml#contact-big")!important;
    -moz-box-orient: vertical!important;
    -moz-box-align: stretch !important;
	}

Comment 10

[Florian Quèze [:florian]]

*** Original post on bio 1066 at 2011-10-12 15:18:49 UTC ***

Fixed by https://hg.instantbird.org/instantbird/rev/549c2079e180

The problem was that the buttons were stealing the focus from the buddylistbox when clicked and that changed the binding used for the selected contact.