954510 - Sametime crash [@ purple_conv_chat_add_users ]

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1075 at 2011-10-14 10:08:00 UTC ***

http://crash-stats.instantbird.com/report/index/9d195f8d-ddd8-4cfd-a223-defa12111013
http://crash-stats.instantbird.com/report/index/b7581e83-6e38-481a-97fb-9a5512111013

Related Pidgin report: http://developer.pidgin.im/ticket/12637

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1075 at 2013-01-08 20:21:26 UTC ***

This pidgin ticket was fixed...but by including a patched dll from Adium (or something like that). The real fix is in the Adium ticket http://trac.adium.im/ticket/16114

I'll see about applying the patches to our code, but I can't test this. :(

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Port of Adium patches

*** Original post on bio 1075 as attmnt 2198 at 2013-01-17 01:46:00 UTC ***

Ports the meanwhile patches from http://hg.adium.im/adium/file/cc6d598f5692/Dependencies/patches, it compiles...I can't say much more than that.

I have no way to test this (and no one has reported this bug), so best we can do is apply it and hope we see the crashes go away?

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Port of Adium patches with better commit message

*** Original post on bio 1075 as attmnt 2205 at 2013-01-19 04:22:00 UTC ***

This just changes the commit message, as discussed with flo [1]. Florian does not want to review this, so I'm going to mark this as checkin-needed.

[1] http://log.bezut.info/instantbird/130118/#m179 through line 200

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8353961 [details] [diff] [review]
Port of Adium patches

*** Original change on bio 1075 attmnt 2198 at 2013-01-19 04:22:52 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1075 at 2013-01-24 13:04:03 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/be881edfb604, hopefully this fixes the issue.