Closed Bug 954518 Opened 10 years ago Closed 10 years ago

The copyright year shouldn't be localizable

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

Details

(Whiteboard: [1.2-wanted])

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1083 at 2011-10-17 11:05:00 UTC ***

At least http://lxr.instantbird.org/instantbird/source/instantbird/locales/en-US/chrome/instantbird/aboutDialog.dtd#9 is causing an issue.
Whiteboard: [1.2-wanted]
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1083 as attmnt 949 at 2011-10-27 00:34:00 UTC ***

This kind of fixes the bug, but I'm not sure if this is OK for l10n.  Otherwise I'm not sure how else it could be fixed.
Attachment #8352691 - Flags: review?(florian)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
*** Original post on bio 1083 at 2011-10-27 09:07:37 UTC ***

> -<!ENTITY copyrightText          "&#169;2007-2011 Contributors. This program is free software; you can redistribute it and/or modify it under the terms of the GNU GPL license version 2.0 or later.">
> +<!-- The copyright year follows the copyrightText entity. -->
> +<!ENTITY copyrightText          "Contributors. This program is free software; you can redistribute it and/or modify it under the terms of the GNU GPL license version 2.0 or later.">

I think the name of the string has to change so that localizers are notified of a new string? (I really should do localization stuff myself atleast once to see how this works).

The comment doesn't match with the order of strings in the XUL file?

> +        <description id="copyright" flex="1">&#169;2007-2011 &copyrightText;</description>
Comment on attachment 8352691 [details] [diff] [review]
Patch

*** Original change on bio 1083 attmnt 949 at 2011-10-27 12:20:40 UTC ***

What Mic said:
- the entity name has to change if the meaning of the string changed significantly (don't scratch your head for a new good name, just add a 2 at the end of the current name)
- The comment doesn't seem to match the implementation.
Attachment #8352691 - Flags: review?(florian) → review-
*** Original post on bio 1083 at 2011-10-27 12:30:49 UTC ***

See [1] for a conversation about making the copyright date a non-localizable entity so it can be moved in a different localization.

[1] http://log.bezut.info/instantbird/111027/#m127
Attached patch Patch v2 (obsolete) — Splinter Review
*** Original post on bio 1083 as attmnt 964 at 2011-10-31 22:34:00 UTC ***

Renames the entity, adds the copyright year as an entity in a separate file.
Attachment #8352706 - Flags: review?(florian)
Comment on attachment 8352691 [details] [diff] [review]
Patch

*** Original change on bio 1083 attmnt 949 at 2011-10-31 22:34:13 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352691 - Attachment is obsolete: true
Comment on attachment 8352706 [details] [diff] [review]
Patch v2

*** Original change on bio 1083 attmnt 964 at 2011-10-31 22:47:33 UTC ***

Cancelling this review, flo suggested a better way to do it.
Attachment #8352706 - Flags: review?(florian)
Attached patch Patch v3Splinter Review
*** Original post on bio 1083 as attmnt 965 at 2011-10-31 22:58:00 UTC ***

Avoids the extra file by adding the entity right into aboutDialog.xul. Ideally this could be scripted to update automatically, but that's not currently done.
Attachment #8352707 - Flags: review?(florian)
Comment on attachment 8352706 [details] [diff] [review]
Patch v2

*** Original change on bio 1083 attmnt 964 at 2011-10-31 22:58:27 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352706 - Attachment is obsolete: true
Comment on attachment 8352707 [details] [diff] [review]
Patch v3

*** Original change on bio 1083 attmnt 965 at 2011-10-31 23:01:04 UTC ***

Looks good, and much simpler than the previous version.

Thanks for fixing this! :)
Attachment #8352707 - Flags: review?(florian) → review+
*** Original post on bio 1083 at 2011-11-10 00:50:01 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/f90c2648a35d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.