Closed
Bug 954521
Opened 10 years ago
Closed 10 years ago
No entities in outgoing tweets.
Categories
(Chat Core :: Twitter, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: florian, Assigned: clokep)
References
Details
(Whiteboard: [1.2-wanted])
Attachments
(1 file)
1.29 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1087 at 2011-10-18 20:06:00 UTC *** We need to include an include_entities parameter to https://dev.twitter.com/docs/api/1/post/statuses/update and https://dev.twitter.com/docs/api/1/post/statuses/retweet/%3Aid requests.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [1.2-wanted]
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1087 as attmnt 914 at 2011-10-21 00:01:00 UTC *** This simply fix adds the proper parameter, I'm not totally happy with the formatting for the retweet method, but it seemed to be the best way to do it. I tested this with both a retweet and a regular tweet.
Attachment #8352656 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8352656 [details] [diff] [review] The Fix *** Original change on bio 1087 attmnt 914 at 2011-10-25 17:08:38 UTC *** Looks good (I haven't tested it myself, but you said you have). We agreed on IRC on a slightly different formatting for the reTweet method, using an intermediate url variable.
Attachment #8352656 -
Flags: review?(florian) → review+
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1087 at 2011-10-26 23:25:59 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/f8d66422ae98
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•