Closed
Bug 954522
Opened 10 years ago
Closed 10 years ago
Twitter timeline's normalizedName shouldn't be localized
Categories
(Chat Core :: Twitter, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(2 files)
4.49 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
1.69 KB,
patch
|
Details | Diff | Splinter Review |
*** Original post on bio 1088 at 2011-10-18 20:08:00 UTC *** Currently, the timeline logs don't end up in the same folder depending on the UI locale, which makes one think "OMG, some of my logs have been lost!" when switching from a build in one locale to a build in another locale.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1088 as attmnt 912 at 2011-10-19 21:24:00 UTC *** The obvious solution here seems to just add a normalizedName getter to Conversation.prototype in twitter.js. However, I wonder if we shouldn't redefine purpleIConversation.name and purpleIConversation.title so that their difference is obvious and useful.
Attachment #8352654 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Comment 2•10 years ago
|
||
Comment on attachment 8352654 [details] [diff] [review] Patch *** Original change on bio 1088 attmnt 912 at 2011-10-19 21:38:54 UTC *** I agree this is a more elegant solution and the changes look good! Thanks for fixing this.
Attachment #8352654 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1088 at 2011-10-20 10:36:57 UTC *** The sad thing about this change is, it's going to break the list of logs for all the users who have been using only a localized version of Instantbird 1.0 or 1.1. :-( I wonder if it's possible to add a workaround somewhere to avoid that.
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1088 as attmnt 913 at 2011-10-20 10:48:00 UTC *** A workaround could be something like this (totally untested!). I'm not sure if I prefer this code or the brokenness it hides...
Comment 5•10 years ago
|
||
*** Original post on bio 1088 at 2011-10-20 11:57:55 UTC *** (In reply to comment #3) > The sad thing about this change is, it's going to break the list of logs for > all the users who have been using only a localized version of Instantbird 1.0 > or 1.1. :-( I had thought of this, but wasn't sure we wanted to add a work around at all for it. I'd tend to think that Twitter logs might not be used very often and that we can just ignore the brokenness (we could add something to the FAQ as well "Where did my Twitter logs go?" with directions to copy the files from the localized to the nonlocalized folder.)
Comment 6•10 years ago
|
||
*** Original post on bio 1088 at 2011-10-20 22:48:34 UTC *** Attachment 8352654 [details] [diff] (bio-attmnt 912) is checked in as http://hg.instantbird.org/instantbird/rev/3ae73e3b04e0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•