954523 - Crash [@ ssl_nss_handshake_cb]

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Benedikt Pfeifer]

*** Original post on bio 1089 at 2011-10-18 20:43:00 UTC ***

Double clicking an account to connect it and disconnect it immediately again crashes sometimes.

Report ID         Date Submitted
bp-41d6eabc-a1e0-4b82-b0af-d2bd52111018 18.10.2011 22:33 (Yahoo iirc)
bp-85d55a5c-2629-41a5-b2e3-c94142111018 18.10.2011 22:32 (ICQ iirc)
bp-6056d57f-41fb-4ef9-a95a-fd31d2111018 18.10.2011 22:30 (ICQ iirc)

Comment 1

[Florian Quèze [:florian]]

*** Original post on bio 1089 at 2011-10-18 20:44:49 UTC ***

Probably somehow forcing NSS to handshake on an already closed socket.

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1089 at 2012-04-08 22:56:23 UTC ***

It turns out the real cause is some prpls corrupting the NSS socket by writing data to it before the end of the handshake when they are disconnected (either because of a user action or a connection error) before being fully connected.

This is easily reproducible with the oscar prpl.

I pushed a fix as http://hg.instantbird.org/instantbird/rev/40aa9e7e5ea0 and as while debugging I added some possibly valuable debug messages, I pushed them as http://hg.instantbird.org/instantbird/rev/ceb11e06a1fc.

Resolving as FIXED \o/.