All users were logged out of Bugzilla on October 13th, 2018

No notification when the user's nick is mentioned in the twitter timeline

RESOLVED FIXED in 1.2

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
*** Original post on bio 1095 at 2011-10-19 20:44:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
(Assignee)

Comment 1

5 years ago
Created attachment 8352653 [details] [diff] [review]
Patch

*** Original post on bio 1095 as attmnt 911 at 2011-10-19 20:44:00 UTC ***

The twitter code doesn't use the writeMessage method of GenericConvChatPrototype, so the containsNick property isn't set automatically.

The patch is totally untested, but seemed obvious.
Attachment #8352653 - Flags: review?(clokep)
Comment on attachment 8352653 [details] [diff] [review]
Patch

*** Original change on bio 1095 attmnt 911 at 2011-10-19 21:29:28 UTC ***

Looks good, I'm not sure how we missed this one either.
Attachment #8352653 - Flags: review?(clokep) → review+
*** Original post on bio 1095 at 2011-10-20 22:39:40 UTC ***

Checked-in as http://hg.instantbird.org/instantbird/rev/937d6c06b2d8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.