Closed
Bug 954529
Opened 11 years ago
Closed 11 years ago
No notification when the user's nick is mentioned in the twitter timeline
Categories
(Chat Core :: Twitter, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
|
804 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1095 at 2011-10-19 20:44:00 UTC ***
*** Due to BzAPI limitations, the initial description is in comment 1 ***
|
Assignee | |
Comment 1•11 years ago
|
||
*** Original post on bio 1095 as attmnt 911 at 2011-10-19 20:44:00 UTC ***
The twitter code doesn't use the writeMessage method of GenericConvChatPrototype, so the containsNick property isn't set automatically.
The patch is totally untested, but seemed obvious.
Attachment #8352653 -
Flags: review?(clokep)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8352653 [details] [diff] [review]
Patch
*** Original change on bio 1095 attmnt 911 at 2011-10-19 21:29:28 UTC ***
Looks good, I'm not sure how we missed this one either.
Attachment #8352653 -
Flags: review?(clokep) → review+
|
|
||
Comment 3•11 years ago
|
||
*** Original post on bio 1095 at 2011-10-20 22:39:40 UTC ***
Checked-in as http://hg.instantbird.org/instantbird/rev/937d6c06b2d8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•