95453 - highlighting text and clicking on 'Left Align' adds <br>

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[shrirang khanzode]

win 0815 trunk

steps:
1 launch composer and open the file attached
2 highlight the 'second line' and click on 'Left Align' in toolbar
3 Observe that the 'second line' gets pushed to the third line and caret goes to 
  far left on second line

expected: Contents of the second line should go to the left and should not get 
pushed down

Comment 1

[shrirang khanzode]

Attachment: testcase

Comment 2

[rubydoo123]

actually what is happening is that an extra div is being inserted with a br. 
When the second line is aligned left, the two lines are incorrectly broken 
apart. To reproduce this problem -- do the following steps:

1. enter both lines of text on the same line
2. highlight the entire line and set the formatting - b,i and u
3. while the line is still selected, align center
4. set the caret to where you want to break the line, and hit enter
 look at the code - you will see this:
        <div align="Center"><u><i><b>line one<br>
         line two</b></i></u></div>
5. set the caret in the second line and select align left, the code now looks 
like this:
        <div align="Center"><u><i><b>line one<br></b></i></u>
           <div align="Left"><br></div>
           <u><i><b>line two</b></i></u>
        </div>
The resulting code should be this:

<div align="Center"><u><i><b>line one</b></i></u></div>
<div align="Left"><u><i><b>line two</b></i></u></div>

the result will be as expected, teh second line will be left aligned and there 
will not be a blank line in between

Comment 3

[Joe Francis]

097

Comment 4

[TucsonTester1]

confirmed on mac os x build 2001121805, Platform/OS needs to be changed to ALL.

Comment 5

[michael wendell]

Changed Platform and OS to all/all per above comments.

Comment 6

[Joe Francis]

pushing off 098 to 099

Comment 7

[Syd Logan]

minusing, please beg to differ if you beg to differ

Comment 8

[Joe Francis]

the swami says: things that will not land in 099!

Comment 9

[Kevin McCluskey (gone)]

Moving bugs to Mozilla1.1 that are not EDITORBASE+.

Comment 10

[Joe Francis]

ugh.  in recent builds hitting undo at the end of this causes text in the first 
line to be replicated in the second line.

Comment 11

[rubydoo123]

removing myself from the cc list

Comment 12

[Joe Francis]

The trunk is the wave of the future!

Comment 13

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 14

[Joe Francis]

[ushing these out as far as bugzilla will let me.  I'll pull them back as I work
on them.

Comment 15

[saari (gone)]

needs testing, should be fixed

Comment 16

[rubydoo123]

using current trunk build, this works fine now

Comment 17

[rubydoo123]

verified