Closed Bug 954530 Opened 10 years ago Closed 10 years ago

Add "Visible tags..." entry to contacts listbox background context menu too

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 1096 at 2011-10-19 21:35:00 UTC ***

Currently only available in the context menu of tag headers, but is there a reason why it shouldn't also be an entry when right-clicking on the buddy list background? (That context menu currently only contains 'Show offline buddies')
*** Original post on bio 1096 at 2011-10-20 09:32:11 UTC ***

I've noticed this too (and didn't file a bug about it:( ). I'd like to have it there, too.
*** Original post on bio 1096 at 2011-10-20 09:41:43 UTC ***

I think it's a good idea. :-)

I'm a bit concerned by the possible user confusion if they check more tags to be visible and they don't appear (because there's currently no only contact in that tag) though.
*** Original post on bio 1096 by frk <vectorspin AT gmail.com> at 2011-11-18 19:23:48 UTC ***

Another look at this issue:

Setup: XP SP3
iBird v.1.1

1. Running program with imported categories (e.g. Buddies, Friends, Work, etc.)
2. Accidentally "X" one of the categories
3. Couldn't figure out how to get it back (tried right-clicking in the window, looking through options menu, etc.)
4. Had to go into IRC to figure out how to get them back

I think the proposed solution would resolve this.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1096 as attmnt 1187 at 2012-02-21 20:59:00 UTC ***

I hope I didn't forget any permutation ;)

Also changed: "Show offline buddies" no longer appears on conversations on hold.
Attachment #8352937 - Flags: review?(florian)
*** Original post on bio 1096 at 2012-02-21 21:04:17 UTC ***

(In reply to comment #2)
> I'm a bit concerned by the possible user confusion if they check more tags to
> be visible and they don't appear (because there's currently no only contact in
> that tag) though.

Sorry, I don't think I understand this comment - how has anything changed e.g through this patch?
*** Original post on bio 1096 at 2012-02-21 21:23:11 UTC ***

"no only contact" -> "no online contact". Sorry about that :-/.
*** Original post on bio 1096 at 2012-02-21 21:38:12 UTC ***

(In reply to comment #6)
> "no only contact" -> "no online contact". Sorry about that :-/.

OK, that makes sense :) I don't think it's going to be a big issue because anyone who can find the context menu to change the visible tags will also at the same time discover "Show offline buddies".

It's a separate issue. If one wanted to change it (e.g. by briefly showing the group header - which I think would be just as confusing to someone who doesn't understand what is happening), the behaviour already happens when one selects a tag with only offline contacts, and I don't think a bug is even filed for it.
Attached patch Optional additional patch (obsolete) — Splinter Review
*** Original post on bio 1096 as attmnt 1188 at 2012-02-21 22:06:00 UTC ***

I also propose this independent patch, which removes the context menu from the section header labels in the buddy list ("Contacts" and "Conversations on hold"). It feels wrong for these layout elements to have context menu entries.
Attachment #8352938 - Flags: review?(florian)
*** Original post on bio 1096 at 2012-02-21 22:10:17 UTC ***

(In reply to comment #8)
> It feels wrong for these layout elements to have context menu entries.

Another option would be to have a context menu on the "Contacts" label (with "View tags" and "Show offline buddies"), but not on the "Conversations on hold" label.
Comment on attachment 8352937 [details] [diff] [review]
Patch

*** Original change on bio 1096 attmnt 1187 at 2012-06-07 13:31:12 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352937 - Flags: review?(florian) → review?(clokep)
Comment on attachment 8352938 [details] [diff] [review]
Optional additional patch

*** Original change on bio 1096 attmnt 1188 at 2012-06-07 13:31:49 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352938 - Flags: review?(florian) → review?(clokep)
Comment on attachment 8352937 [details] [diff] [review]
Patch

*** Original change on bio 1096 attmnt 1187 at 2012-06-13 00:56:30 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352937 - Flags: review?(clokep) → review+
Comment on attachment 8352938 [details] [diff] [review]
Optional additional patch

*** Original change on bio 1096 attmnt 1188 at 2012-06-13 00:57:01 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352938 - Flags: review?(clokep) → review+
*** Original post on bio 1096 at 2012-06-13 00:59:04 UTC ***

For clarity (since this took me a while to figure out): this is referring to the "background", which is only visible if the window is bigger than the number of buddies to give empty space at the bottom.

Anyway, these changes look fine and work well.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Hardware: x86 → All
Summary: Add "Visible tags..." entry to contacts window background context menu too → Add "Visible tags..." entry to contacts listbox background context menu too
Whiteboard: [checkin-needed]
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1096 as attmnt 1606 at 2012-06-14 14:37:00 UTC ***

Also works when there are no tags at all (when no account or buddies exist).
Attachment #8353363 - Flags: review?(florian)
Comment on attachment 8352937 [details] [diff] [review]
Patch

*** Original change on bio 1096 attmnt 1187 at 2012-06-14 14:37:34 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352937 - Attachment is obsolete: true
Comment on attachment 8352938 [details] [diff] [review]
Optional additional patch

*** Original change on bio 1096 attmnt 1188 at 2012-06-14 14:37:34 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352938 - Attachment is obsolete: true
Whiteboard: [checkin-needed]
Comment on attachment 8353363 [details] [diff] [review]
Patch

*** Original change on bio 1096 attmnt 1606 at 2012-11-03 00:21:01 UTC ***

I think it's strange to display the "Visible Tags..." item when the buddy list is completely empty (eg. because we are offline, or because there's no online buddy, and the user hasn't checked 'Show Offline buddies'), but I think this is overall an improvement, and it's been waiting for too long, so if you insist I may r+ as is.
Attachment #8353363 - Flags: review?(florian) → review-
*** Original post on bio 1096 at 2012-11-03 00:22:21 UTC ***

Maybe you can just check that the buddy list richlistbox has children, instead of the "haveTags = !!Services.tags.getTags().length;" check?
Attached patch PatchSplinter Review
*** Original post on bio 1096 as attmnt 2043 at 2012-11-04 18:19:00 UTC ***

Yes, that's better.
Attachment #8353802 - Flags: review?(florian)
Comment on attachment 8353363 [details] [diff] [review]
Patch

*** Original change on bio 1096 attmnt 1606 at 2012-11-04 18:19:58 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353363 - Attachment is obsolete: true
Comment on attachment 8353802 [details] [diff] [review]
Patch

*** Original change on bio 1096 attmnt 2043 at 2012-11-04 18:33:02 UTC ***

Thanks, I like it much better this way! :-)
Attachment #8353802 - Flags: review?(florian) → review+
*** Original post on bio 1096 at 2012-11-05 01:49:13 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/c5e36103d80e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.