Closed Bug 954554 Opened 10 years ago Closed 10 years ago

No longer possible to double click a tweet to reply to it

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

References

Details

(Whiteboard: [1.2-blocking])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1121 at 2011-10-27 14:55:00 UTC ***

Regression from bug 954498 (bio 1062).
Blocks: 954498
Whiteboard: [1.2-blocking]
*** Original post on bio 1121 at 2011-10-27 16:30:09 UTC ***

(In reply to comment #0)
> Regression from bug 954498 (bio 1062).

Do we just wish to move the "Copy link to Tweet" to a different location or a more complicated solution?
*** Original post on bio 1121 at 2011-10-27 16:46:33 UTC ***

(In reply to comment #1)

> Do we just wish to move the "Copy link to Tweet" to a different location or a
> more complicated solution?

I don't know. Whatever makes the most sense.
*** Original post on bio 1121 as attmnt 974 at 2011-11-06 14:36:00 UTC ***

I took the easy route of just swapping the actions for Copying a link to a tweet and replying to a tweet.
Attachment #8352716 - Flags: review?(florian)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
*** Original post on bio 1121 as attmnt 975 at 2011-11-06 14:47:00 UTC ***

Flo wanted reply & retweet next to each other, the next best place for this seems to be as the last action.
Attachment #8352717 - Flags: review?(florian)
Comment on attachment 8352716 [details] [diff] [review]
Swap Reply to Tweet and Copy Link to Tweet

*** Original change on bio 1121 attmnt 974 at 2011-11-06 14:47:32 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352716 - Attachment is obsolete: true
Attachment #8352716 - Flags: review?(florian)
Comment on attachment 8352717 [details] [diff] [review]
Put Copy Link to Tweet as the last action

*** Original change on bio 1121 attmnt 975 at 2011-11-09 22:20:31 UTC ***

r=me for the code changes, but not for the broken hand editing of the diff :(.
Attachment #8352717 - Flags: review?(florian) → review+
*** Original post on bio 1121 at 2011-11-10 00:50:43 UTC ***

Sorry for the issues with the diff. :( I'll try to get a better editor. :P

Checked in as http://hg.instantbird.org/instantbird/rev/6c5abb266d47
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.