Closed
Bug 954591
Opened 10 years ago
Closed 10 years ago
Follow-up to bug 1112: names not matched when alias is set
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: benediktp, Assigned: aleth)
Details
Attachments
(1 file)
433 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1159 at 2011-11-10 09:58:00 UTC *** I noticed that my nick isn't marked as active and found out that this happens, when an alias is set for an account. Make sure to restart Instantbird before trying to reproduce due to bug 954590 (bio 1158).
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1159 at 2011-11-10 12:16:52 UTC *** The reason is that the alias is not shown in the nicklist either (which is what the 'setting to active' code compares the speaker name with). So unless the user's nick is handled differently (which I can't see at first glance), the problem is in getParticipants().
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1159 as attmnt 1007 at 2011-11-18 19:47:00 UTC *** Fix: Never use an alias to compute the colour of a nick or message. Note in passing: Aliases do not appear in the participant list; nor should they, as they are local and thus useless in terms of interaction with the server (e.g to ping a participant you need the nick, not an alias).
Attachment #8352749 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1159 at 2011-11-18 21:48:48 UTC *** PS: Consistency would imply bug 954072 (bio 636) should be resolved invalid.
Updated•10 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
Reporter | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1159 at 2011-11-19 09:18:19 UTC *** (In reply to comment #2) > Created attachment 8352749 [details] [diff] [review] (bio-attmnt 1007) [details] > Patch > > Fix: Never use an alias to compute the colour of a nick or message. > > Note in passing: Aliases do not appear in the participant list; nor should > they, as they are local and thus useless in terms of interaction with the > server (e.g to ping a participant you need the nick, not an alias). (In reply to comment #3) > PS: Consistency would imply bug 954072 (bio 636) should be resolved invalid. Yes, I think so. We still might need a way to tell which alias (used in the conversation area) and which nick (in the nicklist) belong together.
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1159 at 2011-11-19 14:10:39 UTC *** (In reply to comment #4) > Yes, I think so. We still might need a way to tell which alias (used in the > conversation area) and which nick (in the nicklist) belong together. Once this patch lands, one way to tell is that the colors match ;)
Comment 6•10 years ago
|
||
Comment on attachment 8352749 [details] [diff] [review] Patch *** Original change on bio 1159 attmnt 1007 at 2011-11-22 23:03:56 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352749 -
Flags: review?(florian) → review+
Comment 7•10 years ago
|
||
*** Original post on bio 1159 at 2011-11-23 04:43:17 UTC *** Fixed in http://hg.instantbird.org/instantbird/rev/8c0b516103ed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•