954594 - Focus contact window on 'Restore' in tray context menu

Status: RESOLVED FIXED

(Instantbird Graveyard :: Contacts window, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1162 at 2011-11-12 17:11:00 UTC ***

...or leave it as it is, but have it bring the contact window to the front, giving it focus.

Comment 1

[aleth [:aleth]]

*** Original post on bio 1162 at 2011-11-19 19:49:14 UTC ***

I think the second option is the better one.

I can't test this, nor am I certain, but would it not be enough to add a focus() call after http://lxr.instantbird.org/instantbird/source/instantbird/components/mintrayr/trayToolkit.cpp#445 ?

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1162 at 2011-12-08 23:01:42 UTC ***

(In reply to comment #1)
> I think the second option is the better one.

I agree. Focusing the window seems a better idea.


> I can't test this, nor am I certain, but would it not be enough to add a
> focus() call after
> http://lxr.instantbird.org/instantbird/source/instantbird/components/mintrayr/trayToolkit.cpp#445
> ?

I don't know. I guess we may also do it from JS, getting the blist window with Services.wm.getEnumerator("Messenger:blist") and then focus it.

Comment 3

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1162 as attmnt 1138 at 2012-01-25 22:03:00 UTC ***

Even simpler. (And I don't think this window can be null!)

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8352883 [details] [diff] [review]
Patch

*** Original change on bio 1162 attmnt 1138 at 2012-01-26 00:27:46 UTC ***

This looks fine. Thanks.

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1162 at 2012-01-26 00:47:05 UTC ***

Thanks for fixing this, checked in as http://hg.instantbird.org/instantbird/rev/744a55d0f708