954601 - Make tab completion smarter

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, enhancement)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1169 at 2011-11-15 15:32:00 UTC ***

The tab completion algorithm could be smarter to take into account active participants (people who've said something recently) and also people who have recently pinged you.

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1169 as attmnt 1001 at 2011-11-17 21:34:00 UTC ***

When there are multiple possible completions, but only one of them is an active nick, complete with that nick, while nevertheless displaying all possible completions in a system message just in case.

Comment 2

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1169 as attmnt 1003 at 2011-11-17 22:40:00 UTC ***

Now without system message when a whole nick is completed.

For future reference, on IRC the following alternative behaviour was also discussed: If at least one nick is active in the list of possible completions, ignore the inactive nicks.

Comment 3

[aleth [:aleth]]

Comment on attachment 8352743 [details] [diff] [review]
Patch

*** Original change on bio 1169 attmnt 1001 at 2011-11-17 22:40:34 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1169 as attmnt 1004 at 2011-11-17 22:48:00 UTC ***

Obvious mistake hopefully now absent.

Comment 5

[aleth [:aleth]]

Comment on attachment 8352745 [details] [diff] [review]
Patch

*** Original change on bio 1169 attmnt 1003 at 2011-11-17 22:48:49 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1169 as attmnt 1005 at 2011-11-17 23:09:00 UTC ***

Obeys style guide ;)

Comment 7

[aleth [:aleth]]

Comment on attachment 8352746 [details] [diff] [review]
Patch

*** Original change on bio 1169 attmnt 1004 at 2011-11-17 23:09:37 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8352747 [details] [diff] [review]
Patch

*** Original change on bio 1169 attmnt 1005 at 2011-11-18 00:26:29 UTC ***

Looks good!

Comment 9

[Florian Quèze [:florian]]

*** Original post on bio 1169 at 2011-11-18 01:12:30 UTC ***

Fixed, thanks!
https://hg.instantbird.org/instantbird/rev/b6e0a30d6b95

Comment 10

[Florian Quèze [:florian]]

*** Original post on bio 1169 at 2011-11-20 22:29:36 UTC ***

Follow-up:
https://hg.instantbird.org/instantbird/rev/e91301c49e93 - fix the completion of commands in IM conversations, as discussed on IRC.