No tab completion after brackets etc.

RESOLVED FIXED in 1.2

Status

Instantbird
Conversation
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

4 years ago
*** Original post on bio 1185 at 2011-11-23 21:02:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
(Assignee)

Comment 1

4 years ago
Created attachment 8352758 [details] [diff] [review]
Patch

*** Original post on bio 1185 as attmnt 1015 at 2011-11-23 21:02:00 UTC ***

Tab completion fails to ignore non-whitespace, but word-delimiting characters such as brackets and the @ character. For example, "(a" does not suggest completions for "a", only for "(a". However, it should do the former whenever the latter fails.

Fix included.
Attachment #8352758 - Flags: review?(florian)
(Assignee)

Comment 2

4 years ago
Created attachment 8352759 [details] [diff] [review]
Patch

*** Original post on bio 1185 as attmnt 1016 at 2011-11-23 21:19:00 UTC ***

Excess whitespace removal
Attachment #8352759 - Flags: review?(florian)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8352758 [details] [diff] [review]
Patch

*** Original change on bio 1185 attmnt 1015 at 2011-11-23 21:19:19 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352758 - Attachment is obsolete: true
Attachment #8352758 - Flags: review?(florian)
(Assignee)

Comment 4

4 years ago
Created attachment 8352760 [details] [diff] [review]
Patch

*** Original post on bio 1185 as attmnt 1017 at 2011-11-23 23:42:00 UTC ***

As all elements of the regex are optional (due to the "?"), it will never return null; also, the second match may be "" if the user is attempting to complete non-alphanumerics (e.g. "["). Must therefore check the returned matches themselves are not empty.
Attachment #8352760 - Flags: review?(florian)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8352759 [details] [diff] [review]
Patch

*** Original change on bio 1185 attmnt 1016 at 2011-11-23 23:42:04 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352759 - Attachment is obsolete: true
Attachment #8352759 - Flags: review?(florian)
(Assignee)

Comment 6

4 years ago
Created attachment 8352761 [details] [diff] [review]
Patch

*** Original post on bio 1185 as attmnt 1018 at 2011-11-23 23:44:00 UTC ***

Typo fix.
Attachment #8352761 - Flags: review?(florian)
(Assignee)

Comment 7

4 years ago
Comment on attachment 8352760 [details] [diff] [review]
Patch

*** Original change on bio 1185 attmnt 1017 at 2011-11-23 23:44:01 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352760 - Attachment is obsolete: true
Attachment #8352760 - Flags: review?(florian)
Comment on attachment 8352761 [details] [diff] [review]
Patch

*** Original change on bio 1185 attmnt 1018 at 2011-12-13 22:14:16 UTC ***

Looks good. We discussed on IRC this additional change that removes the twitter specific case and removes the ":" suffix in case there was some non-alphabetic characters before the nick in the textbox):

diff -u b/instantbird/content/conversation.xml b/instantbird/content/conversation.xml
--- b/instantbird/content/conversation.xml
+++ b/instantbird/content/conversation.xml
@@ -521,7 +521,8 @@
             if (!this._conv.isChat)
               return;
 
-            firstWordSuffix = ": ";
+            if (this._conv.account.protocol.id != "prpl-twitter")
+              firstWordSuffix = ": ";
 
             completions = Object.keys(this.buddies);
             let outgoingNick = this._conv.nick;
@@ -538,7 +539,6 @@
           let matchingCompletions = completions.filter(condition);
           if (!matchingCompletions.length && words[1]) {
             word = words[1];
-            firstWordSuffix = " ";
             matchingCompletions = completions.filter(condition);
           }
           if (!matchingCompletions.length)
Attachment #8352761 - Flags: review?(florian) → review+
*** Original post on bio 1185 at 2011-12-13 23:24:28 UTC ***

https://hg.instantbird.org/instantbird/rev/9809dcddbd91
Assignee: nobody → aleth
Severity: normal → minor
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.