Closed
Bug 954637
Opened 10 years ago
Closed 10 years ago
Non-ASCII characters not correctly encoded in account aliases, account options, and user display name
Categories
(Instantbird Graveyard :: Account manager, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: bugzilla, Assigned: florian)
References
Details
(Whiteboard: [1.2-blocking])
Attachments
(1 file, 1 obsolete file)
10.54 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1205 by Px <px AT i.kiev.ua> at 2011-12-11 14:56:00 UTC *** In latest nightly Cyrillic support in alias broken. Steps to reproduce. 1. Go to Tools - Accounts, press Properties 2. In Alias field enter Тест (Test) http://img831.imageshack.us/img831/3099/20111211164936.png 3. Press Ok and then Properties again, you see that Cyrillic text is broken http://img217.imageshack.us/img217/2520/20111211164922.png Additional info: Same problem is in the buddy list (text looks like not decoded from unicode) http://img861.imageshack.us/img861/3236/20111211164946.png Also, with this version Cyrillic works in both places just fine version 1.2a1pre (20111104044337) Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20111104 Instantbird/1.2a1pre
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1205 at 2012-02-13 20:47:36 UTC *** This may be a regression from bug 954193 (bio 759). I'm not sure, but if current builds break all non-ASCII account aliases and display names, this should probably block 1.2.
Whiteboard: [1.2-blocking]
Comment 2•10 years ago
|
||
*** Original post on bio 1205 at 2012-02-18 15:46:55 UTC *** Confirmed regression from Instantbird 1.1.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1205 as attmnt 1179 at 2012-02-20 16:50:00 UTC *** I think this also affects the account usernames (likely for QQ) and passwords (that we read to copy into the password manager).
Attachment #8352928 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8352928 [details] [diff] [review] Patch *** Original change on bio 1205 attmnt 1179 at 2012-02-20 16:56:29 UTC *** >diff --git a/chat/components/src/imAccounts.js b/chat/components/src/imAccounts.js >@@ -141,21 +141,28 @@ function imAccount(aKey, aName, aPrplId) [...] >- this.prefBranch.setCharPref(kPrefAccountName, aName); >+ let str = Cc["@mozilla.org/supports-string;1"] >+ .createInstance(Ci.nsISupportsString); >+ str.data = aName;; Remove the double ; please. I also thought we'd want to fix this in jsProtoHelper: http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#116 but that seems to be an empty function (even though I'm fairly certain I use it in IRC...) is that just handled by the account implementation code in imAccounts.js? r+ with that change.
Attachment #8352928 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1205 as attmnt 1180 at 2012-02-20 18:16:00 UTC *** Account options are affected too...
Attachment #8352929 -
Flags: review?(clokep)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8352928 [details] [diff] [review] Patch *** Original change on bio 1205 attmnt 1179 at 2012-02-20 18:16:24 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352928 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
Comment on attachment 8352929 [details] [diff] [review] Patch v2 *** Original change on bio 1205 attmnt 1180 at 2012-02-20 18:36:25 UTC *** Looks good! Thanks for taking a second look!
Attachment #8352929 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 8•10 years ago
|
||
*** Original post on bio 1205 at 2012-02-21 10:16:52 UTC *** Fixed: https://hg.instantbird.org/instantbird/rev/69ff22bff5e3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: Cyrillic support in alias and buddy list broken → Non-ASCII characters not correctly encoded in account aliases, account options, and user display name
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•