Closed Bug 954674 Opened 10 years ago Closed 10 years ago

JSON log viewer scrolls to end of conversation on opening log

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

(Whiteboard: [1.2-wanted])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1242 at 2012-01-23 21:21:00 UTC ***

Behaviour inherited from opening conversations in the usual context.
*** Original post on bio 1242 at 2012-01-23 21:29:10 UTC ***

I hesitated filing this because I am not sure how long the log viewer will remain in its present form anyway. flo might have a better idea ;)
*** Original post on bio 1242 at 2012-01-23 23:11:48 UTC ***

Adding 1.2-wanted because I've just discovered it breaks search (unless you are aware enough to click 'previous' to get results)
Whiteboard: [1.2-wanted]
*** Original post on bio 1242 at 2012-03-05 01:27:07 UTC ***

An additional detail: At the end of the log, the log viewer shows the time difference between the last message in the log and the present ;)
*** Original post on bio 1242 at 2012-04-04 17:15:57 UTC ***

(In reply to comment #3)
> An additional detail: At the end of the log, the log viewer shows the time
> difference between the last message in the log and the present ;)

I filed this as bug 954776 (bio 1343).
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1242 as attmnt 1417 at 2012-04-29 21:43:00 UTC ***

- Simple fix. Haven't noticed any unwelcome side-effects.
Attachment #8353169 - Flags: review?(florian)
Attached patch PatchSplinter Review
*** Original post on bio 1242 as attmnt 1418 at 2012-04-29 21:47:00 UTC ***

Better move it before the appendmessage calls actually, though it makes no noticeable difference.
Attachment #8353170 - Flags: review?(florian)
Comment on attachment 8353169 [details] [diff] [review]
Patch

*** Original change on bio 1242 attmnt 1417 at 2012-04-29 21:47:46 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353169 - Attachment is obsolete: true
Attachment #8353169 - Flags: review?(florian)
Comment on attachment 8353170 [details] [diff] [review]
Patch

*** Original change on bio 1242 attmnt 1418 at 2012-04-29 21:53:00 UTC ***

Seems OK, or at the very least it doesn't seem risky :).
Attachment #8353170 - Flags: review?(florian) → review+
*** Original post on bio 1242 at 2012-04-29 23:07:16 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/0bae2c9cdccd

Thanks for fixing this!
Assignee: nobody → aleth
Status: NEW → RESOLVED
Closed: 10 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.